-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR for leveraged authorization constraints (issue #898) #911
base: develop
Are you sure you want to change the base?
PR for leveraged authorization constraints (issue #898) #911
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i like the messages you chose for this one, great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start! Just a few things that I noticed.
7846255
to
d61b3f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing my previous feedback. This looks really good! Just one small typo that I noticed.
3742eae
Co-authored-by: Gabeblis <[email protected]>
87af556
3742eae
to
87af556
Compare
Looks like this PR is good to go. It just needs to be rebased @Rene2mt |
Committer Notes
This PR adds the constraints in issue #898. These include
leveraged-authorization-has-authorized-users
- Ensure every "system" component linked to a leveraged authorization has at least one authorized user. NOTE - Current implementation only checks that the component (that represents the leveraged authorization service) has at least oneresponsible-party
with arole-id
. Issue SSP Leveraged Authorization Component Entries #898 called for checking theparty-uuid
, and this can be added, however, it seems the rev 5 SSP template table 6.1 may actually be looking for role rather the the respectiveparty
.leveraged-authorization-has-component
- Ensure every leveraged authorization entry is associated with exactly one component of type "system"leveraged-authorization-has-implementation-point
- Ensure every "system" component linked to a leveraged authorization has exactly one implementation point property, and that it is set to "external"leveraged-authorization-has-information-type
- Ensure every "system" component linked to a leveraged authorization has at least one information-type FedRAMP extension propertyleveraged-authorization-has-nature-of-agreement
- Ensure every "system" component linked to a leveraged authorization has exactly onenature-of-agreement
FedRAMP extension propertyFedRAMP Developer Hub documentation changes are being prepared in a separate PR
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.