Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for leveraged authorization constraints (issue #898) #911

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

Rene2mt
Copy link
Member

@Rene2mt Rene2mt commented Nov 18, 2024

Committer Notes

This PR adds the constraints in issue #898. These include

  • leveraged-authorization-has-authorized-users - Ensure every "system" component linked to a leveraged authorization has at least one authorized user. NOTE - Current implementation only checks that the component (that represents the leveraged authorization service) has at least one responsible-party with a role-id. Issue SSP Leveraged Authorization Component Entries #898 called for checking the party-uuid, and this can be added, however, it seems the rev 5 SSP template table 6.1 may actually be looking for role rather the the respective party.
  • leveraged-authorization-has-component - Ensure every leveraged authorization entry is associated with exactly one component of type "system"
  • leveraged-authorization-has-implementation-point - Ensure every "system" component linked to a leveraged authorization has exactly one implementation point property, and that it is set to "external"
  • leveraged-authorization-has-information-type - Ensure every "system" component linked to a leveraged authorization has at least one information-type FedRAMP extension property
  • leveraged-authorization-has-nature-of-agreement - Ensure every "system" component linked to a leveraged authorization has exactly one nature-of-agreement FedRAMP extension property

FedRAMP Developer Hub documentation changes are being prepared in a separate PR

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Rene2mt Rene2mt linked an issue Nov 18, 2024 that may be closed by this pull request
14 tasks
@Rene2mt Rene2mt marked this pull request as ready for review November 19, 2024 18:26
@Rene2mt Rene2mt requested a review from a team as a code owner November 19, 2024 18:26
wandmagic
wandmagic previously approved these changes Nov 19, 2024
Copy link
Collaborator

@wandmagic wandmagic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like the messages you chose for this one, great job!

Copy link
Contributor

@Gabeblis Gabeblis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start! Just a few things that I noticed.

src/validations/constraints/content/ssp-all-VALID.xml Outdated Show resolved Hide resolved
src/validations/constraints/content/ssp-all-VALID.xml Outdated Show resolved Hide resolved
src/validations/constraints/content/ssp-all-VALID.xml Outdated Show resolved Hide resolved
src/validations/constraints/content/ssp-all-VALID.xml Outdated Show resolved Hide resolved
wandmagic
wandmagic previously approved these changes Nov 25, 2024
DimitriZhurkin
DimitriZhurkin previously approved these changes Nov 27, 2024
Copy link
Contributor

@Gabeblis Gabeblis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing my previous feedback. This looks really good! Just one small typo that I noticed.

@Rene2mt Rene2mt dismissed stale reviews from DimitriZhurkin and wandmagic via 3742eae November 27, 2024 15:03
Gabeblis
Gabeblis previously approved these changes Nov 27, 2024
DimitriZhurkin
DimitriZhurkin previously approved these changes Nov 27, 2024
wandmagic
wandmagic previously approved these changes Nov 27, 2024
@Rene2mt Rene2mt dismissed stale reviews from wandmagic, DimitriZhurkin, and Gabeblis via 87af556 December 2, 2024 16:39
@Rene2mt Rene2mt force-pushed the constraints/leveraged-authorization-issue-898 branch from 3742eae to 87af556 Compare December 2, 2024 16:39
@Gabeblis
Copy link
Contributor

Looks like this PR is good to go. It just needs to be rebased @Rene2mt

@aj-stein-gsa
Copy link
Contributor

Hey @Rene2mt I just wanted to check up on this and see if we want to move this forward before or after #828 and namespace shift.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSP Leveraged Authorization Component Entries
5 participants