Add responsible-party-is-person constraint #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rene2mt
force-pushed
the
constraints/responsible-party-is-person
branch
2 times, most recently
from
6450680 to
cc33ee8
Compare
Rene2mt
changed the title
|
Added issue GSA/automate.fedramp.gov#57 for required documentation updates. |
aj-stein-gsa
requested changes
Sep 16, 2024
Rene2mt
force-pushed
the
constraints/responsible-party-is-person
branch
from
cc33ee8 to
a978a29
Compare
|
Hey @aj-stein-gsa once I rebased, some of the validations were no longer passing due to modifications I had made to the ssp-all-INVALID.xml test content, so the latest commit rolled those changes back and created a separate test SSP for this new responsible-party-is-person constraint. |
Rene2mt
force-pushed
the
constraints/responsible-party-is-person
branch
from
09ddd50 to
4829962
Compare
aj-stein-gsa
force-pushed
the
feature/external-constraints
branch
from
c59e72c to
f6d2009
Compare
Rene2mt
changed the base branch from
feature/external-constraints
to
develop
aj-stein-gsa
force-pushed
the
constraints/responsible-party-is-person
branch
from
965d5fb to
89f03f7
Compare
aj-stein-gsa
requested changes
Sep 26, 2024
Rene2mt
force-pushed
the
constraints/responsible-party-is-person
branch
from
89f03f7 to
664edf4
Compare
aj-stein-gsa
previously approved these changes
Sep 26, 2024
src/validations/constraints/content/ssp-responsible-party-is-person-INVALID.xml
Outdated
Show resolved
Hide resolved
This was referenced Oct 11, 2024
Rene2mt
force-pushed
the
constraints/responsible-party-is-person
branch
from
664edf4 to
14d9b36
Compare
kyhu65867
requested changes
Oct 24, 2024
src/validations/constraints/content/ssp-responsible-party-is-person-INVALID.xml
Outdated
Show resolved
Hide resolved
DimitriZhurkin
previously approved these changes
Oct 25, 2024
Rene2mt
force-pushed
the
constraints/responsible-party-is-person
branch
from
14d9b36 to
5e2b250
Compare
wandmagic
approved these changes
Oct 28, 2024
aj-stein-gsa
approved these changes
Oct 28, 2024
14 tasks
brian-ruf
pushed a commit
to brian-ruf/fedramp-automation
that referenced
this pull request
Nov 8, 2024
* Add responsible-party-is-person constraint * Add help-url * Update constraint to only validate required roles * Make updates resolving review feedback comments
This was referenced Nov 13, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
This PR adds responsible-party-is-person constraint, which checks that
responsible-partyassemblies withrole-idset to certain values (e.g., "system-owner", "authorizing-official", "authorizing-official-poc", "system-poc-management", "system-poc-technical", "system-poc-other", and "information-system-security-officer") must reference apartyof type "person".All Submissions:
If applicable, does this PR reference the issue it addresses and explain how it addresses the issue?By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.