Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update guidance for roles and responsible-party issue #57 #83

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

Rene2mt
Copy link
Member

@Rene2mt Rene2mt commented Oct 11, 2024

This PR addresses issue #57 , clarifying requirements around which roles are required and what type of party ("person") must be associated. It also provides information on (prior) roles that are no longer required by FedRAMP.

NOTE: This PR adds a section that is referenced by the help-url of the "responsible-party-is-person" constraint, so this PR should be merged prior to PR GSA/fedramp-automation/pull/652 being merged

@Rene2mt Rene2mt requested review from a team October 11, 2024 17:54
@Rene2mt Rene2mt added the documentation Improvements or additions to documentation label Oct 17, 2024
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I did not get to the review of this PR sooner. Can you address my one high-level concern, because I am not sure where this change would have come from.

@Rene2mt Rene2mt force-pushed the responsible-party-issue-57 branch from d4f651f to a9c2488 Compare October 18, 2024 14:23
Copy link

@kyhu65867 kyhu65867 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving because I don't think my feedback is significant enough to block, but I do want it to be considered.

@Rene2mt Rene2mt force-pushed the responsible-party-issue-57 branch from a9c2488 to 8b9201a Compare October 23, 2024 20:48
@Rene2mt Rene2mt requested a review from aj-stein-gsa October 23, 2024 20:50
@Rene2mt
Copy link
Member Author

Rene2mt commented Oct 23, 2024

@aj-stein-gsa I rebased to resolve conflicts with the data-center documentation PR. Other than that, all should be the same.

@aj-stein-gsa aj-stein-gsa merged commit c1d1396 into GSA:develop Oct 24, 2024
aj-stein-gsa pushed a commit that referenced this pull request Nov 12, 2024
* Update guidance for roles and responsible-party issue #57

* Fix documentation for "authorizing-official" role
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: 🚢 Ready to Ship
Development

Successfully merging this pull request may close these issues.

3 participants