Skip to content

Commit

Permalink
Make updates resolving review feedback comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Rene2mt committed Oct 25, 2024
1 parent f2dfed7 commit 5e2b250
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 18 deletions.
2 changes: 1 addition & 1 deletion src/validations/constraints/content/ssp-all-VALID.xml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
<role id="system-poc-management">
<title>Information System Management Point of Contact (POC)</title>
<description>
<p>The highest level manager who responsible for system operation on behalf of the System Owner.</p>
<p>The highest level manager who is responsible for system operation on behalf of the System Owner.</p>
</description>
</role>
<role id="system-poc-technical">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,18 +72,6 @@
<responsible-party role-id="authorizing-official">
<party-uuid>11111111-0000-4000-9000-000000000001</party-uuid>
</responsible-party>
<responsible-party role-id="authorizing-official-poc">
<party-uuid>11111111-0000-4000-9000-000000000001</party-uuid>
</responsible-party>
<responsible-party role-id="system-poc-management">
<party-uuid>11111111-0000-4000-9000-000000000001</party-uuid>
</responsible-party>
<responsible-party role-id="system-poc-technical">
<party-uuid>11111111-0000-4000-9000-000000000001</party-uuid>
</responsible-party>
<responsible-party role-id="system-poc-other">
<party-uuid>11111111-0000-4000-9000-000000000001</party-uuid>
</responsible-party>
<responsible-party role-id="information-system-security-officer">
<party-uuid>11111111-0000-4000-9000-000000000001</party-uuid>
</responsible-party>
Expand Down
10 changes: 5 additions & 5 deletions src/validations/constraints/fedramp-external-constraints.xml
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,11 @@
<prop namespace="https://docs.oasis-open.org/sarif/sarif/v2.1.0" name="help-url" value="https://automate.fedramp.gov/documentation/ssp/4-ssp-template-to-oscal-mapping/#data-centers" />
<message>There must be one or more alternate data center(s).</message>
</expect>
<index name="index-person-party-uuid" target="map:merge(party[@type='person'] ! map:entry(@uuid,.))?*">
<formal-name>Index of parties of type "person".</formal-name>
<description>This index is a list of the UUIDs of all of the parties that are type "person" in the document.</description>
<key-field target="@uuid"/>
</index>
<index-has-key id="responsible-party-is-person" name="index-person-party-uuid" target="./responsible-party[(@role-id='system-owner') or (@role-id='information-system-security-officer')]" level="ERROR">
<prop namespace="https://docs.oasis-open.org/sarif/sarif/v2.1.0" name="help-url" value="https://automate.fedramp.gov/documentation/ssp/4-ssp-template-to-oscal-mapping/#summary-of-ssp-roles-requirements"/>
<key-field target="party-uuid"/>
Expand All @@ -195,11 +200,6 @@
<expect id="role-defined-information-system-security-officer" target="." test="role[@id eq 'information-system-security-officer']" level="ERROR">
<message>A FedRAMP SSP must define a role for the point of contact for an information system security officer.</message>
</expect>
<index name="index-person-party-uuid" target="map:merge(party[@type='person'] ! map:entry(@uuid,.))?*">
<formal-name>In-Scope UUIDs for party assemblies of type "person".</formal-name>
<description>An index of UUIDs for party assemblies of type "person".</description>
<key-field target="@uuid"/>
</index>
</constraints>
</context>
<context>
Expand Down

0 comments on commit 5e2b250

Please sign in to comment.