Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Icebox escape pods now properly target the Icemoon surface #1214

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25740
Original PR: tgstation/tgstation#80452

About The Pull Request

This fixes Icebox escape pods only landing in certain ruins when launched early.

/area/icemoon/surface/outdoors only shows up in a few select ruins. The new area value used to decide a landing point, /area/icemoon/surface/outdoors/unexplored/rivers/no_monsters, covers the majority of the Icemoon surface.

Why It's Good For The Game

Closes #78735.

Escape pods might not very useful on Icebox, but this makes using them less hazardous. You're guaranteed to at least land somewhere safe and away from the station.

Changelog

🆑 Rhials
fix: Icebox escape pods will now land randomly on the surface, instead of only in certain ruins.
/:cl:

…MDB IGNORE] (#25740)

* Icebox escape pods now properly target the Icemoon surface (#80452)

## About The Pull Request

This fixes Icebox escape pods only landing in certain ruins when
launched early.

`/area/icemoon/surface/outdoors` only shows up in a few select ruins.
The new area value used to decide a landing point,
`/area/icemoon/surface/outdoors/unexplored/rivers/no_monsters`, covers
the majority of the Icemoon surface.
## Why It's Good For The Game

Closes #78735.

Escape pods might not very useful on Icebox, but this makes using them
less hazardous. You're guaranteed to at least land somewhere safe and
away from the station.
## Changelog
:cl: Rhials
fix: Icebox escape pods will now land randomly on the surface, instead
of only in certain ruins.
/:cl:

* Icebox escape pods now properly target the Icemoon surface

---------

Co-authored-by: Rhials <[email protected]>
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the Stale label Dec 27, 2023
@Iajret Iajret merged commit 5b9dea6 into master Dec 27, 2023
23 checks passed
@Iajret Iajret deleted the upstream-mirror-25740 branch December 27, 2023 20:42
AnywayFarus added a commit that referenced this pull request Dec 27, 2023
Iajret pushed a commit that referenced this pull request Mar 1, 2024
* pipebomb (#81529)

## About The Pull Request


![image](https://github.com/tgstation/tgstation/assets/70376633/2c2a8ddf-d210-468b-9403-f7de4fa1fd9b)

removes IEDs, these are its replacement


![image](https://github.com/tgstation/tgstation/assets/70376633/95cc67d7-ed41-481b-9b9d-f31897fdb46d)

this recipe produces a finished pipebomb

you can craft pipes (of the atmos kind) with some metal
then you can make it into a pair of halved pipes with a welder
then you stuff in items for extra effect (optional, only works if it
does something)
then you put in welding fuel OR gunpowder (no other options as of now,
gunpowder is a better explosive)
cable finishes that part
after that, you can attach an unsecured assembly to finish the bomb

also this is the math for the explosion, power is decided by fuel

![image](https://github.com/tgstation/tgstation/assets/70376633/95ac3101-a2af-4bdc-9730-6c9c20195b59)

using it in-hand activates the assembly, using it off-hand allows you to
configure the assembly

## Why It's Good For The Game

IEDs suck and stuff and this would be a better upgrade/replacement
because with assemblies you could make a circuit sentient pipebomb or
gift a pipebomb via cargo or something and gimmicks i guess
## Changelog
:cl:
add: Pipebombs
del: Improvised Firebombs
/:cl:

* pipebomb

---------

Co-authored-by: jimmyl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants