Use precalculated bounding boxes of image-features to speed up image feature query #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhmetNSimsek
changed the title
AhmetNSimsek
commented
Mar 26, 2024
AhmetNSimsek
force-pushed
the
enh_use_precalc_img_bboxes
branch
2 times, most recently
from
36002ee to
8b1fb9f
Compare
AhmetNSimsek
force-pushed
the
enh_use_precalc_img_bboxes
branch
from
8b1fb9f to
5e2efa0
Compare
… providers independent of building volumes
update reftag
use branch specific branch
fix: preconfigure bbox e2e test parameters
fix(test): preconf bbox ng format should not overwrite clip flag
use config branch
do not set max_bytes or resolution_mm
fix image test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The profiling revealed that most time is spend fetching the boundingboxes of images. When this information is cached, the query itself takes less than a second (on 11th Gen Intel(R) Core(TM) i5-1145G7, 16 GB memory). Therefore, this PR allows the bounding box information to be precalculated and stored in the configs to be used in run time. I suggest that we utilize this method for all image features until the new spatial query system is settled.
EDT: Tests are failing due to issues with data-proxy. (lint is failing due to unused import which is caused by using a specific config branch)
EDT 2: Requires: