-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bbox field to bigbrain sections #45
Conversation
57f0034
to
28936a3
Compare
@xgui3783 This PR aims to speed up the spatial queries. Timo has suggested we should also add bounding boxes to maps and spaces. This, however, bloats the maps with many volumes. Any alternative ideas on how to resolve this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with two comments:
1/ I am concerned that by adding bounding box, we now have two sources of truth. I would make sense to do a sanity check (at least when the bounding box property is added) to ensure that both sources of truth agrees
2/ when you do json.dump
in python, it does not automatically add a new line at EOF. it would be ideal to write a new line after json.dump
The downside of using the static typing approach, I suppose. the alternative is to add fetching of bounding box to warm cache |
c3efeeaf2b9c2e2581eb3481fe0d93468f9bf01b)
Please see FZJ-INM1-BDA/siibra-python#583 for the intended use.
EDT: Need to recalculate after FZJ-INM1-BDA/siibra-python#591