Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bbox field to bigbrain sections #45

Merged
merged 11 commits into from
Oct 31, 2024
Merged

Conversation

AhmetNSimsek
Copy link
Collaborator

@AhmetNSimsek AhmetNSimsek commented Mar 25, 2024

Please see FZJ-INM1-BDA/siibra-python#583 for the intended use.

EDT: Need to recalculate after FZJ-INM1-BDA/siibra-python#591

@AhmetNSimsek AhmetNSimsek force-pushed the enh_use_precalc_img_bboxes branch from 57f0034 to 28936a3 Compare April 10, 2024 09:08
@AhmetNSimsek AhmetNSimsek requested a review from xgui3783 April 10, 2024 09:55
@AhmetNSimsek
Copy link
Collaborator Author

@xgui3783 This PR aims to speed up the spatial queries. Timo has suggested we should also add bounding boxes to maps and spaces. This, however, bloats the maps with many volumes. Any alternative ideas on how to resolve this?

Copy link
Member

@xgui3783 xgui3783 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with two comments:

1/ I am concerned that by adding bounding box, we now have two sources of truth. I would make sense to do a sanity check (at least when the bounding box property is added) to ensure that both sources of truth agrees

2/ when you do json.dump in python, it does not automatically add a new line at EOF. it would be ideal to write a new line after json.dump

@xgui3783
Copy link
Member

This, however, bloats the maps with many volumes. Any alternative ideas on how to resolve this?

The downside of using the static typing approach, I suppose.

the alternative is to add fetching of bounding box to warm cache

@xgui3783 xgui3783 marked this pull request as ready for review October 22, 2024 11:52
@AhmetNSimsek AhmetNSimsek merged commit 706e4cb into master Oct 31, 2024
8 checks passed
@AhmetNSimsek AhmetNSimsek deleted the enh_use_precalc_img_bboxes branch October 31, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants