Toggle crosshair and perspective background

[fsdavid]

No description provided.

[xgui3783]

Thanks for the new PR @fsdavid .

Do you want me to re add the review from last time?

Also, somewhat related, can you go through https://github.com/FZJ-INM1-BDA/siibra-explorer/branches and delete the branches you don't need?

[fsdavid]

Sure, I will clean the branches. I will use review from here #1148

[xgui3783]

In addition, can you also please add typing to the methods you introduced?

edit: and also change the PR name to something that makes sense?

[xgui3783]

You can set .drawSubstrates to falsy, I think.

It should achieve the same result, perhaps more performant (since gl will not even need to try to draw the substrate)

[fsdavid]

Setting it simply true/false is changing the default opacity of the background

[fsdavid]

@xgui3783 Should be fixed now

[xgui3783]

Codewise, Just some minor changes.

Thanks for the good work.

[xgui3783]

also, it appears that the background colour changer is not working properly.

at start, it sets to black

and on update, it will always reset to white.

Can you add some tests to ensure the methods works as intended?

I have a feeling that we want this in the gear icon mat menu, rather than in config. It's rather hard to find.

[fsdavid]

I have a feeling that we want this in the gear icon mat menu, rather than in config. It's rather hard to find.

To avoid overloading of the perspective views gear icon, which more feels a quick setting of the perspective view than all 4 views, I think using the Settings window is a good way. I also would like if users will get used to using the settings window, as it could hold more settings.

[xgui3783]

I have a feeling that we want this in the gear icon mat menu, rather than in config. It's rather hard to find.

To avoid overloading of the perspective views gear icon, which more feels a quick setting of the perspective view than all 4 views, I think using the Settings window is a good way. I also would like if users will get used to using the settings window, as it could hold more settings.

I agree that perspective setting menu can become quite overloaded.

At the same time, I also think at least the substrate colour can be configured there, since it is a more natural place to try to find the setting.

We can duplicate the UI in user setting menu (where it is currently), as well

[xgui3783]

also, I found a bug, steps to reproduce:

1/ load jba 2.9,
2/ go to setting, turn off axis, background, close setting dialog (noting that axis and substrate disappears, as expected)
3/ go to setting again, axis/background checkbox are both checked.

I would argue use a dedicated service, or ngRx/componentStore which can be used to persist component state.

[fsdavid]

@xgui3783 on my local machine viewerCtrlCmp.component.ts > ViewerCtrlCmp > toggleParcVsbl > if _flagDelin is false > calls schedulRedraw FAILED test is failing? (it was not failed here, but I think potentially it could) could it be caused by setTimeout? if it is, would you have any idea how to get nehubaviewer containing config on to set initial values?