Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to hide crosshair in orthogonal views and bckground colouring of section planes in 3D view #1131

Open
xgui3783 opened this issue Jan 11, 2022 · 11 comments · May be fixed by #1153
Open
Assignees
Labels

Comments

@xgui3783
Copy link
Member

No description provided.

@xgui3783
Copy link
Member Author

xgui3783 commented Feb 3, 2022

@fsdavid can you link the (correct) PR or reference it here?

Can you also tag either Timo or me to review this card when ready?

@fsdavid
Copy link
Contributor

fsdavid commented Feb 3, 2022

Sure

@fsdavid fsdavid linked a pull request Feb 3, 2022 that will close this issue
This was unlinked from pull requests Feb 3, 2022
@fsdavid fsdavid linked a pull request Feb 3, 2022 that will close this issue
@fsdavid fsdavid assigned xgui3783 and dickscheid and unassigned xgui3783 and fsdavid Feb 3, 2022
@dickscheid
Copy link
Collaborator

Can we have a URL and short explanation in order to review this?

@fsdavid
Copy link
Contributor

fsdavid commented Jun 21, 2022

You can find the demo here:
https://siibra-explorer.apps-dev.hbp.eu/devviewsettings/#/

The setting could be found in the user settings popup window (User icon at top right corner and then settings), under the "Viewer" tab.

@xgui3783
Copy link
Member Author

feedbacks:

dropdown is not very distinguishable from side panel (see screenshot)

Screenshot from 2022-07-26 15-02-28

dataset -> not accurate

  • missing name
  • missing description

@xgui3783
Copy link
Member Author

there should be a selector for dataset (from 1000brains vs others), then further slider for matrices inside the dataset

@xgui3783
Copy link
Member Author

in future, more granular filter (cohort, etc)

@dickscheid
Copy link
Collaborator

dickscheid commented Aug 30, 2022

@xgui3783 your above comments seem to refer to connectivity browser, not "hide crosshair" functionality. consider moving them.

@dickscheid
Copy link
Collaborator

as per discussion today: Ship quickly to release with a simple keyboard shortcut, but without an icon / extended configuration dialog. Configuration dialogues will be revisited later on.

@xgui3783
Copy link
Member Author

xgui3783 commented Aug 30, 2022

as per discussion today: Ship quickly to release with a simple keyboard shortcut, but without an icon / extended configuration dialog. Configuration dialogues will be revisited later on.

already ready to be released in this commit: f64a706 in this PR: #1227

@xgui3783
Copy link
Member Author

Re: UI redesign, it has been moved to #1203

let's keep this issue focused on implementing UI for toggling cross hair and background color (and/or if we still want to implement them)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants