Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show mini perspective on maximised slice views #1124

Closed
wants to merge 4 commits into from
Closed

Show mini perspective on maximised slice views #1124

wants to merge 4 commits into from

Conversation

fsdavid
Copy link
Contributor

@fsdavid fsdavid commented Dec 13, 2021

No description provided.

@fsdavid fsdavid requested a review from xgui3783 December 13, 2021 15:59
@xgui3783
Copy link
Member

can you remind me what this PR is suppose to do?

@fsdavid
Copy link
Contributor Author

fsdavid commented Dec 13, 2021

can you remind me what this PR is suppose to do?

It should show a mini perspective view (with slider) when slice views are maximized

@xgui3783
Copy link
Member

can you remind me what this PR is suppose to do?

It should show a mini perspective view (with slider) when slice views are maximized

can you rename the PR accordingly then?

also, does this PR supercede #1089 ?

@fsdavid fsdavid changed the title Dev mini perspective Show mini perspective on maximised slice views Dec 13, 2021
@fsdavid
Copy link
Contributor Author

fsdavid commented Dec 13, 2021

Yes, it's supercede #1089 . I've closed that PR

@fsdavid
Copy link
Contributor Author

fsdavid commented Feb 3, 2022

Issue: https://github.com/FZJ-INM1-BDA/siibra/issues/44

@fsdavid fsdavid linked an issue Feb 3, 2022 that may be closed by this pull request
Possibility to hide crosshair in orthogonal views and bckground colouring of section planes in 3D view #1131
Open
@fsdavid fsdavid removed a link to an issue Feb 3, 2022
Possibility to hide crosshair in orthogonal views and bckground colouring of section planes in 3D view #1131
Open
@fsdavid fsdavid marked this pull request as draft April 8, 2022 20:44
@fsdavid fsdavid marked this pull request as ready for review May 11, 2022 07:20
@fsdavid fsdavid marked this pull request as draft May 11, 2022 07:20
@xgui3783
Copy link
Member

@fsdavid , sorry I missed reviewing this PR.

Can you rebase your changes to the current dev? there are way too many merge conflicts for now.

(when you push new commits, the docker image should also rebuild, and the preview link should then work again)

@fsdavid
Copy link
Contributor Author

fsdavid commented Aug 30, 2022

@xgui3783 Sure, I will rebase the branch :)

@fsdavid
Copy link
Contributor Author

fsdavid commented Aug 30, 2022

Actually, this branch is moved here: #1180
Sorry, I will close this one.

@fsdavid fsdavid closed this Aug 30, 2022
@xgui3783 xgui3783 deleted the dev_mini_perspective branch August 30, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xgui3783 xgui3783 Awaiting requested review from xgui3783

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fsdavid @xgui3783