Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes CMake dependency to controller_manager #156

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Removes CMake dependency to controller_manager #156

merged 1 commit into from
Sep 28, 2023

Conversation

francocipollone
Copy link
Collaborator

@francocipollone francocipollone commented Sep 28, 2023 •
edited
Loading

🦟 Bug fix

Fixes #

Summary

  • controller_manager is a exec_dependency, no need to request at CMake level
  • Making source build pass in ROS build farm:

See https://build.ros2.org/job/Hdev__andino__ubuntu_jammy_amd64/1/

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

@francocipollone francocipollone mentioned this pull request Sep 28, 2023
Closed
6 tasks
@francocipollone francocipollone merged commit c142691 into humble Sep 28, 2023
3 checks passed
@francocipollone francocipollone deleted the francocipollone/remove_controller_manager branch September 28, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jballoffet jballoffet jballoffet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Andino Roadmap
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francocipollone @jballoffet