Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ForcedSleep with Anesthesia for surgery #2684

Merged

Conversation

pontaoski
Copy link
Contributor

@pontaoski pontaoski commented Jan 10, 2025

About the PR

Surgeries now rely on a Anesthesia effect which allows "incapacitate someone combatwise" and "allow painless surgery" to be different concerns.

NO2, Nocturine, and Chloral Hydrate have all been granted the new Anesthesia status effect, which allows them to serve this role in surgery.

Why / Balance

As it is, slime people can't be anesthesised using NO2, and expanding anesthesia to include them by adding more sources of ForcedSleep is horrible for combat balance.

Relying on ForcedSleep also has other weirdness, such as narcolepsy or the psionic mass sleep being able to replace anesthesia for surgery.

The solution then is to use a new Anesthesia component and effect instead of trying to overload ForcedSleep.

Technical details

  • AnesthesiaComponent is added
  • surgery system now checks for AnesthesiaComponent instead of ForcedSleepComponent
  • add Anesthesia status effect
  • NO2, Nocturine, and Chloral Hydrate all have the new Anesthesia status effect

Media

moth-anesthesia.mp4

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Changelog

🆑

  • tweak: Surgery now requires anesthesia rather than forced sleep
  • tweak: Chloral hydrate, nitrous oxide, and nocturine now serve as anesthesia

@pontaoski pontaoski requested a review from a team as a code owner January 10, 2025 17:23
@github-actions github-actions bot added size/XS Under 16 lines S: Needs Review Changes: C# Changes any cs files and removed S: Needs Review labels Jan 10, 2025
@pontaoski pontaoski force-pushed the work/jblackquill/anesthesia branch from 45b1486 to 9ad5a24 Compare January 10, 2025 18:05
@pontaoski pontaoski requested a review from a team as a code owner January 10, 2025 18:05
@github-actions github-actions bot added S: Needs Review Changes: YML Changes any yml files size/S 16-63 lines and removed S: Needs Review size/XS Under 16 lines labels Jan 10, 2025
@pontaoski pontaoski changed the title Allow chloral hydrate to serve as anesthesia for a surgery Replace ForcedSleep with Anesthesia for surgery Jan 10, 2025
@pontaoski pontaoski force-pushed the work/jblackquill/anesthesia branch from 9ad5a24 to cb9dd70 Compare January 10, 2025 18:09
Lyndomen
Lyndomen previously approved these changes Jan 10, 2025
Content.Shared/_DV/Surgery/AnesthesiaComponent.cs Outdated Show resolved Hide resolved
Content.Shared/_DV/Surgery/AnesthesiaComponent.cs Outdated Show resolved Hide resolved
Content.Shared/_DV/Surgery/AnesthesiaComponent.cs Outdated Show resolved Hide resolved
@deltanedas deltanedas enabled auto-merge (squash) January 11, 2025 06:31
@deltanedas deltanedas merged commit 056c98c into DeltaV-Station:master Jan 11, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files S: Needs Review size/S 16-63 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants