Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2151] Update all actions for OIDC #106

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[2151] Update all actions for OIDC #106

wants to merge 5 commits into from

Conversation

saliceti
Copy link
Member

@saliceti saliceti commented Dec 19, 2024

Context

Authenticate Github actions to Azure with OIDC instead of service principal secret

Changes proposed in this pull request

Update all actions to remove the need for azure credentials

  • The main change is in the set-arm-environment-variables and set-kubelogin-environment actions to refactor the environment variables
  • Then all actions depending on them are updated
  • The actions using konduit are updated to allow passing the namespace explicitly so they don't require the cluster admin role

Guidance to review

See DFE-Digital/itt-mentor-services#1253

Before merging

⚠️ Remove TEMP commit

After merging

Update DFE-Digital/itt-mentor-services#1253 to point at master

Checklist

  • I have performed a self-review of my code, including formatting and typos
  • I have cleaned the commit history
  • I have added the Devops label
  • I have attached the pull request to the trello card

Use OIDC authentication when azure-credentials is not provided

Also update kubelogin to 1.6
All actions authenticating to Azure need configuration without
azure-credentials
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant