Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2151] Enable Github actions OIDC for services #335

Merged
merged 5 commits into from
Dec 31, 2024
Merged

[2151] Enable Github actions OIDC for services #335

merged 5 commits into from
Dec 31, 2024

Conversation

saliceti
Copy link
Member

@saliceti saliceti commented Dec 19, 2024

Context

Create federated credentials so that github actions for all services can authenticate using OIDC instead of service principal secret

Depends on:

Changes proposed in this pull request

  • Create managed identities and federated credentials for ITTMS and Publish
  • Update new_service template
  • Update documentation

Guidance to review

Checklist

  • I have performed a self-review of my code, including formatting and typos
  • I have cleaned the commit history
  • I have added the Devops label
  • I have attached the pull request to the trello card

- Replace azure-credentials in all github actions workflows
- Simplify terraform kubernetes provider configuration since all
  clusters are RBAC enabled.
@saliceti saliceti marked this pull request as ready for review December 31, 2024 15:41
Copy link
Contributor

@vipin-dfe vipin-dfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@saliceti saliceti merged commit 9e85443 into main Dec 31, 2024
6 checks passed
@saliceti saliceti deleted the oidc-ga branch December 31, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants