Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2151] GitHub actions OIDC #1281

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[2151] GitHub actions OIDC #1281

wants to merge 7 commits into from

Conversation

saliceti
Copy link
Member

@saliceti saliceti commented Jan 3, 2025

Context

Deploy to AKS using Github actions and OIDC instead of a service principal secret

Depends on:

Changes proposed in this pull request

  • Change workflows to avoid using azure credentials
  • Add dv_review and pt_review environments
  • Delete enable/disable maintenance page (replaced)

Guidance to review

The branch tmp-tf-modules-no-oidc uses the updated terraform modules and github actions but keeps using service principal secret authentication (SPN). It is useful for testing the new code doesn't break existing services.

Successful runs:

Link to Trello card

https://trello.com/c/F9hmE3if

@saliceti saliceti added the deploy A Review App will be created for PRs with this label label Jan 3, 2025
Copy link

github-actions bot commented Jan 3, 2025

@saliceti saliceti force-pushed the 843-github-actions-oidc branch from 61c043d to 19f0ea2 Compare January 3, 2025 17:27
@saliceti saliceti deployed to pt_review January 3, 2025 18:08 — with GitHub Actions Active
@saliceti saliceti marked this pull request as ready for review January 3, 2025 18:19
@saliceti saliceti requested review from a team as code owners January 3, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy A Review App will be created for PRs with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant