Hds 1854 new cookie consent rebase

[Arkkimaagi]

Description

Preliminary draft, still things to do:

• Tests
• Theming support
• Support for not reporting "unlawful cookies" when user simply changes their mind
• Trigger banner from a button
• Add current timestamp to group on save
• Documentation (in its own branch, not here)

---

Related Issue

Closes #

Motivation and Context

How Has This Been Tested?

Demos:

Links to demos are in the comments

Screenshots (if appropriate):

Add to changelog

• Added needed line to changelog

[NikoHelle]

The second argument is an object, which could also include the first argument, so there would only be one. Code is cleaner and it is easier to pick params and set defaults.

// outside constructor
const defaults = {
language: 'en',
theme = 'bus',
...rest
}`

constructor(options){
 const parsedOptions = {...defaults, ...options}
 const { language, theme, ...rest} = parsedOptions;
}

(The third one is not really needed.)

[NikoHelle]

After this change, there could only be one private property "this.settings" instead of

 #LANGUAGE;
  #THEME;
  #TARGET_SELECTOR;
  #SPACER_PARENT_SELECTOR;
  #PAGE_CONTENT_SELECTOR;
  #SUBMIT_EVENT = false;
  #SETTINGS_PAGE_SELECTOR;

And the this.settings could be passed in function calls

await this.#render(this.#LANGUAGE, siteSettings, false, settingsPageElement);

could be

await this.#render(this.settings, false);

and

const message = getTranslation(
      this.#SITE_SETTINGS.translations,
      'settingsSaved',
      this.#LANGUAGE,
      this.#SITE_SETTINGS.fallbackLanguage,
    );

could also be simplified.

[NikoHelle]

This fail-safe seems overkill. Documentation should be enough, and if not, just do not publish the constructor in the package if it should never be used.

[NikoHelle]

If constructor is changed to accept only one argument (options), then same here.

[Arkkimaagi]

See below for reasoning behind this choise.

[laurakarhu]

Two tiny remarks I had forgotten pending.

[laurakarhu]

should be suitable line-height-token?

[laurakarhu]

same here, line-heigth token?

[laurakarhu]

Looks good to me!