WIP: HDS-1854 new cookie consent contribution #1289
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- cssTools/post-sass is plugin for postcss - postcss-sass handles syntax (recommended by post-sass) - same stylelint scss config as React package has
Same rules as React packages has
The scss is provided by the hel.fi team
HDS-2241 scss to core
The css is built in another branch
The objects are empty, but sometimes props are needed.
…or sitesettings object, monitoring and removing cookies,localStorage,sessionStorage,indexedDB,cacheStorage,etc
Test Results1 tests 1 ✅ 0s ⏱️ Results for commit ffe41ee. ♻️ This comment has been updated with latest results. |
…wing consenting them via api
…-new-cookie-consent-tests-load-merge
…nsent-tests-load-merge Hds 1854 new cookie consent tests load merge
NikoHelle
force-pushed
the
feature/new-cookie-consent
branch
from
3f37a0f
to
00cb912
Compare
Arkkimaagi
changed the base branch from
feature/new-cookie-consent
to
HDS-1854-new-cookie-consent-rebase
Arkkimaagi
changed the base branch from
HDS-1854-new-cookie-consent-rebase
to
feature/new-cookie-consent
Arkkimaagi
changed the base branch from
feature/new-cookie-consent
to
HDS-1854-new-cookie-consent-rebase
NikoHelle
changed the base branch from
HDS-1854-new-cookie-consent-rebase
to
feature/new-cookie-consent
|
Close this, work is in #1312 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE THIS
Description
Preliminary draft, still things to do:
Related Issue
Closes #
Motivation and Context
How Has This Been Tested?
Demos:
Links to demos are in the comments
Screenshots (if appropriate):
Add to changelog