Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release-4.0.0 ((new-cookie) new cookie consent on top of release-4.0.0 #1383

Open
wants to merge 3 commits into
base: release-4.0.0
Choose a base branch
from

Conversation

mrTuomoK
Copy link
Contributor

@mrTuomoK mrTuomoK commented Oct 17, 2024

Description

New cookie consent rebased to release 4.0.0, also fixed a template bug plus changes the template value literal format in the jsons from ${} -> {{}}

How Has This Been Tested?

  • running builds and tests locally

Demos:

Links to demos are in the comments

Add to changelog

  • needs all kinds of stuff before release still

@mrTuomoK mrTuomoK requested a review from a team October 17, 2024 13:12
@mrTuomoK mrTuomoK changed the title ((new-cookie) new cookie consent on top of release-4.0.0 Release-4.0.0 ((new-cookie) new cookie consent on top of release-4.0.0 Oct 17, 2024
Copy link

github-actions bot commented Oct 17, 2024

Test Results

 1 files  18 suites   3m 27s ⏱️
 9 tests  9 ✅ 0 💤 0 ❌
18 runs  18 ✅ 0 💤 0 ❌

Results for commit f122af8.

♻️ This comment has been updated with latest results.

Copy link

Preview found from hds-demo docs/preview_1383

Demos

Docs
Core Storybook
React Storybook

@mrTuomoK mrTuomoK force-pushed the new-cookie-consent-rebased-to-release-4.0.0 branch from 432df18 to f00db9b Compare October 18, 2024 09:16
@timwessman timwessman self-requested a review October 21, 2024 09:57
Copy link
Contributor

@timwessman timwessman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!

@NikoHelle
Copy link
Contributor

Does this include the feature/new-cookie-consent brach or just the hds-1854-new-cookie-consent-base?

I've lost track what has been merged to where.

@mrTuomoK
Copy link
Contributor Author

mrTuomoK commented Oct 21, 2024

Does this include the feature/new-cookie-consent brach or just the hds-1854-new-cookie-consent-base?

I've lost track what has been merged to where.

This is done from the previous "rebase"-branch @NikoHelle, so it's a continuation/update for the feature/new-cookie-consent

@NikoHelle
Copy link
Contributor

Ok, looks like the merge was done in #1312

Just making sure that the other stuff in feature/new-cookie-consent is not lost. Whatever there still is 😄

@mrTuomoK
Copy link
Contributor Author

Yeah I'm pretty sure this is the last & latest there is :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants