-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth signed writes #18
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Love how it's displayed on MM, really cool !! PS: We can handle loading and refreshing lists, and states in another PR too, happy to do so 🙌, lol don't want to spend your time on it! :) |
// ToDo. Loading states (initial, actions, etc) | ||
// ToDo. Refresh list after action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use something like swr
? or even tanstack react-query (it might be a bit over powered) because they come in with this built in and also some extra goodies like caching etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, happy to try swr
!
This app won't be super intensive on requests, just a couple of forms + /admin... but we can explore if it's worth it.
Maybe in another PR?
Thanks for taking a look @technophile-04 Added some stuff:
Leaving the loading states for now (we can handle them with SWR) |
Following up on #17
A POC for admins to sign write operations with EIP712 signatures.
What do you think @technophile-04 ?