Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth signed writes #18

Merged
merged 6 commits into from
Feb 19, 2024
Merged

Auth signed writes #18

merged 6 commits into from
Feb 19, 2024

Conversation

carletex
Copy link
Contributor

@carletex carletex commented Feb 18, 2024

Following up on #17

A POC for admins to sign write operations with EIP712 signatures.

What do you think @technophile-04 ?

Copy link

vercel bot commented Feb 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
grants-bg ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 11:36am

@technophile-04
Copy link
Member

technophile-04 commented Feb 19, 2024

Admins to sign write operations with EIP712 signatures.

Love how it's displayed on MM, really cool !!

PS: We can handle loading and refreshing lists, and states in another PR too, happy to do so 🙌, lol don't want to spend your time on it! :)

Comment on lines +12 to +13
// ToDo. Loading states (initial, actions, etc)
// ToDo. Refresh list after action
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use something like swr ? or even tanstack react-query (it might be a bit over powered) because they come in with this built in and also some extra goodies like caching etc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, happy to try swr!

This app won't be super intensive on requests, just a couple of forms + /admin... but we can explore if it's worth it.

Maybe in another PR?

@carletex
Copy link
Contributor Author

Thanks for taking a look @technophile-04

Added some stuff:

  • Split review grant in "new" and "completed" for admins to review
  • Check database so only admins can review grants
  • Save address data (from connected address) info on Zustand store. (added a ToDo on SubmitButton in case we want to leverage on the global state)

Leaving the loading states for now (we can handle them with SWR)

@carletex carletex changed the title [WIP] Auth signed writes Auth signed writes Feb 19, 2024
@carletex carletex merged commit 7982fbc into main Feb 19, 2024
3 checks passed
@carletex carletex deleted the 13#auth-signed-writes branch March 6, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants