-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Exploring SIWE + JWT #17
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
will love to hear your take on this (updated the OP comment with some questions). We can also have a call next week. |
Tysm Carlos, working great !
I am kind of 49% on SIWE + JWT and 51% on letting admin every time he do write operation.
Yeah,Intially I was thinking this might be a bad option since whever admin refreshes the page he would need to sign again, But I think we could solve this by telling Admin to sign message(with expiryTimestamp) and store it inside localstorage and always send it while fetching getAllGrants similar to jwt. So we could use this method just to gurad But yup I am all in if we go with JWT + SIWE too !! Also we could add it to whole app and improve stuff like #8 (comment), also gurad
Yeah we can do any write operation with it .... but doing some research there is as such no such good advantage of using server actions besides a bit improved DX(of not creating different routes files and collocation). So I think maybe we should stick to api routes for everything and we are also we versed with it and any which case we need to create some GET routes. Will create a PR to update submit form proposal to api routes 🙌 |
Thanks @technophile-04 !! Super helpful. Let me draft a PR next week with "Admin signs for every write to DB". I like the idea of signing some "admin reads" to and the timestamp. |
Closing this in favor of #18 |
[WIP]
Exploring the option of SIWE + JWT for #13. There are a bunch of things to fix / add... but this is meant to be a POC.
I have a bunch of open questions: