-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin route (soft) view access #96
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice !! Also what if maybe add :
useEffect(() => {
if (!address) router.push("/");
}, [address, router]);
PS: We need use useEffect, if we do if (!address) router.push("/");
directly at page level it gives red warning
Also, incase if we want to redirect user to homepage onError added #96 (comment), but yup even current solution makes sense !! So please feel free to merge it as it 🙌
Hey @technophile-04 , the problem with this is that I'll be interested to know how to fix this for other occasions ( Merging this for now... since I think we'll be changing it soon haha (Austin is more inclined to do a SIWE + validation). I'll open an issue. |
Ohhhhh yes!! my bad, missed it completely sorry :(
Yeah :(, I think since we are using our custom solution Umm not sure what's the best solution is maybe very hacky solution : exposing some kindof But yup this should be solved in Wagm v2 though 🙌 |
Let's soft-protect the /admin route. Data is not secret anyway, but let's now allow /admin direct access.
As we discussed on #18 and #17, if we wanted full protection, we could do SIWE + JWT or signed reads. We might want to consider it in the future.