-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Parsely as VIP Integration #4660
Adds Parsely as VIP Integration #4660
Conversation
2da87c7
to
041ae78
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4660 +/- ##
=============================================
+ Coverage 28.67% 28.98% +0.31%
- Complexity 4661 4692 +31
=============================================
Files 274 276 +2
Lines 20638 20711 +73
=============================================
+ Hits 5918 6004 +86
+ Misses 14720 14707 -13
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comments for easier review.
eef8761
to
20fb066
Compare
b4abc53
to
133e825
Compare
1f8c5ec
to
6a6a13f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your comments are wonderful, thanks for adding them in. I really like the renaming changes you've done, as well as the helper methods that you have added in. Awesome work 💯
ccf1783
to
0a34274
Compare
e019653
to
1365d2f
Compare
…is already activated
@mjangda all of the feedback has been incorporated please have a look again. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing this and it looks good.
Added one suggestion on how to pass through the parsely credentials.
Description
ParselyIntegration
class.Integration
class adds the functionality of activating integration based on the config file provided by VIP.Changelog Description
Adds Parse.ly as VIP Integration
Pre-review checklist
Pre-deploy checklist
Steps to Test
git checkout vip-parsely-41/adds-wp-parsely-vip-integration
vip dev-env start --slug [YOUR_SLUG]
(if no env is available then create it)php
container and place configs (we have to do it manually because as of nowvip dev-env
doesn't have support to auto create this folder/file while creating new envs)docker exec -it [CONTAINER_NAME] /bin/sh
touch /wp/config/integrations-config/parsely-config.php
and adds following contentparsely
can be replaced with any other slug of the integrationwp-parsely
plugin is activated with the SiteID and secrets which are provided by VIP (credentails support will be available onv3.9
and above).\Automattic\VIP\Integrations\activate( 'parsely' );
inplugin-loader.php
file so better to also test this flow.