Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes wp_parsely_managed_options filter from Parse.ly integration #5109

Merged

Conversation

mehmoodak
Copy link
Member

Description

Removes wp_parsely_managed_options filter from Parse.ly integration

Changelog Description

Removes wp_parsely_managed_options filter from Parse.ly integration

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally (or has an appropriate fallback).
  • This change works and has been tested on a Go sandbox.
  • This change has relevant unit tests (if applicable).
  • This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

  • [N/A] VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

  1. Check out PR
  2. Clone wp-parsely (git clone [email protected]:Parsely/wp-parsely.git wp-parsely-3.11)
  3. Add VIP config of Parse.ly integration with only status attribute as mentioned in this PR (Adds Parsely as VIP Integration #4660)
  4. Verify wp-parsely is enabled if status is enabled and UI is not any showing upgrade links

@mehmoodak mehmoodak self-assigned this Dec 22, 2023
@mehmoodak mehmoodak requested a review from a team as a code owner December 22, 2023 19:45
Copy link

sonarcloud bot commented Dec 22, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (971da7e) 28.90% compared to head (c0b963b) 28.80%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #5109      +/-   ##
=============================================
- Coverage      28.90%   28.80%   -0.11%     
+ Complexity      4767     4766       -1     
=============================================
  Files            279      279              
  Lines          20998    20975      -23     
=============================================
- Hits            6070     6041      -29     
- Misses         14928    14934       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rebeccahum rebeccahum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a search to see if anyone was using the filter, looks like not.

Copy link
Contributor

@acicovic acicovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested, but this looks good to me! 🙂

@mehmoodak
Copy link
Member Author

Did a search to see if anyone was using the filter, looks like not.

We only intented to use it internally, thanks for the second look though 👍

@mehmoodak mehmoodak merged commit 32ec8b1 into develop Dec 28, 2023
39 checks passed
@mehmoodak mehmoodak deleted the integrations/remove-managed-options-from-parsely-integration branch December 28, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants