-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes wp_parsely_managed_options filter from Parse.ly integration #5109
Removes wp_parsely_managed_options filter from Parse.ly integration #5109
Conversation
…parsely-integration
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5109 +/- ##
=============================================
- Coverage 28.90% 28.80% -0.11%
+ Complexity 4767 4766 -1
=============================================
Files 279 279
Lines 20998 20975 -23
=============================================
- Hits 6070 6041 -29
- Misses 14928 14934 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a search to see if anyone was using the filter, looks like not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested, but this looks good to me! 🙂
We only intented to use it internally, thanks for the second look though 👍 |
Description
Removes
wp_parsely_managed_options
filter from Parse.ly integrationChangelog Description
Removes
wp_parsely_managed_options
filter from Parse.ly integrationPre-review checklist
Please make sure the items below have been covered before requesting a review:
Pre-deploy checklist
Steps to Test
git clone [email protected]:Parsely/wp-parsely.git wp-parsely-3.11
)wp-parsely
is enabled if status isenabled
and UI is not any showing upgrade links