➕ ADDS: tests for invalid slug during activation in integrations

Automattic · Jul 5, 2023 · 6a6a13f · 6a6a13f
1 parent d6e7b3e
commit 6a6a13f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/integrations/integrations.php b/integrations/integrations.php
@@ -38,7 +38,7 @@ public function register( $integration ): void {
 
 		$slug = $integration->get_slug();
 
-		if ( isset( $this->integrations[ $slug ] ) ) {
+		if ( null !== $this->get( $slug ) ) {
 			throw new InvalidArgumentException( sprintf( 'Integration with slug "%s" is already registered.', $slug ) );
 		}
 

diff --git a/tests/vip-integrations/test-vip-integrations.php b/tests/vip-integrations/test-vip-integrations.php
@@ -68,4 +68,17 @@ public function test__non_integration_subclass__throws_invalidArgumentException(
 
 		$integrations->register( $random_class );
 	}
+
+	/**
+	 * Test activating integration on invalid slug throws error.
+	 */
+	public function test__activating_integration_by_passing_invalid_slug__throws_invalidArgumentException() {
+		$this->expectException( InvalidArgumentException::class );
+
+		$integrations     = new Integrations();
+		$fake_integration = new FakeIntegration( 'fake' );
+
+		$integrations->register( $fake_integration );
+		$integrations->activate( 'invalid-slug' );
+	}
 }