Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HYDRA-780 : Image-based NURBS unit test #54

Merged
merged 19 commits into from
Feb 5, 2024
Merged

HYDRA-780 : Image-based NURBS unit test #54

merged 19 commits into from
Feb 5, 2024

Conversation

debloip-adsk
Copy link
Collaborator

No description provided.

@debloip-adsk debloip-adsk self-assigned this Feb 1, 2024
@debloip-adsk debloip-adsk marked this pull request as ready for review February 1, 2024 16:53
@debloip-adsk debloip-adsk marked this pull request as draft February 1, 2024 16:54
@debloip-adsk debloip-adsk removed their assignment Feb 1, 2024
@debloip-adsk debloip-adsk marked this pull request as ready for review February 1, 2024 20:21
@debloip-adsk debloip-adsk self-assigned this Feb 1, 2024
@debloip-adsk debloip-adsk mentioned this pull request Feb 2, 2024
Merged
@debloip-adsk debloip-adsk removed their assignment Feb 2, 2024
@debloip-adsk debloip-adsk self-assigned this Feb 2, 2024
@debloip-adsk debloip-adsk requested a review from ppt-adsk February 2, 2024 22:52
ppt-adsk
ppt-adsk previously approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@ppt-adsk ppt-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor points you may want to have a look at, otherwise fine, thanks for the test!

test/lib/mayaUsd/render/mayaToHydra/testNurbsPrimitives.py Outdated Show resolved Hide resolved
test/lib/mayaUsd/render/mayaToHydra/testNurbsPrimitives.py Outdated Show resolved Hide resolved
@debloip-adsk
Copy link
Collaborator Author

FYI @lilike-adsk @lanierd-adsk @roopavr-adsk @vlasovi

@debloip-adsk debloip-adsk requested a review from ppt-adsk February 5, 2024 16:12
@debloip-adsk debloip-adsk mentioned this pull request Feb 5, 2024
Merged
@debloip-adsk debloip-adsk added ready-for-merge Development process is finished, PR is ready for merge test labels Feb 5, 2024
@roopavr-adsk roopavr-adsk merged commit 6d54e8e into dev Feb 5, 2024
10 checks passed
@roopavr-adsk roopavr-adsk deleted the debloip/HYDRA-780/image-based-nurbs-tests branch February 5, 2024 17:24
@debloip-adsk debloip-adsk mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppt-adsk ppt-adsk ppt-adsk approved these changes

Assignees

@debloip-adsk debloip-adsk

Labels
ready-for-merge Development process is finished, PR is ready for merge test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@debloip-adsk @ppt-adsk @roopavr-adsk