HYDRA-834 : Add support for text-based data source dump comparisons in tests #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at stream settings (will fail on other platforms)
…pdate reference dumps
…-source-comparisons
ppt-adsk
approved these changes
Jun 3, 2024
debloip-adsk
added
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows us to compare data sources dumped with
HdDebugPrintDataSourcein C++ tests. The printing of floats and doubles can be configured if the USD build used supports it, which allows us to print them with a certain precision and deal with floating point discrepancies between platforms. The compile definitionCONFIGURABLE_DECIMAL_STREAMING_AVAILABLEindicates whether support for configurable float/double streaming is available.Bundled with this PR is a test for some of the NURBS primitives, which while already tested using image diffing by #54, is the test that originally exposed the floating-point printing issue. This allows us to both test the changes to support data source comparison and make sure we successfully handle the original issue.