Adjust image diff threshold for testMayaLights #55
Conversation
|
Yes for macOS specifically, it's causing failures in preflights e.g. for #54, I've checked the output images and it does match the expected result so it looks like just a threshold issue |
If that, could we disable the test on MacOS first? I found if we use a pretty large threshold, we might miss the real failures. Meanwhile, we need to investigate why MacOS produced different images than Win/Linux for most test cases. |
| IMAGE_DIFF_FAIL_THRESHOLD = 0.01 | ||
| IMAGE_DIFF_FAIL_PERCENT = 0.2 | ||
| @property | ||
| def imageDiffFailThreshold(): |
There was a problem hiding this comment.
great, miss "self" as parameter?
There was a problem hiding this comment.
Yes definitely, though somehow it ran fine locally without it. Thanks for catching it
lilike-adsk
added
ready-for-merge
lilike-adsk
deleted the
debloip/adjust-image-diff-threshold-maya-lights
branch
No description provided.