[5.0] Fix unlinkable block exceptions when block-log-retain-blocks = 0 #2007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linh2931
approved these changes
Dec 20, 2023
spoonincode
approved these changes
Dec 20, 2023
greg7mdp
approved these changes
Dec 20, 2023
This was referenced Dec 20, 2023
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running with
block-log-retain-blocks = 0, manyunlinkable blockexceptions were generated.Do not attempt to apply blocks that are before LIB.
Blocks are received before LIB because we always sync from LIB to make sure we see all possible forks. However, between the request and the blocks coming in, LIB can move. When running with no block log, these blocks are not known to have already been processed. However, there is never any reason to attempt to apply blocks that are <= LIB, so just drop them instead of attempting to apply them.
Resolves #2006