[5.0] Test: Check for unlinkable blocks while syncing #2008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linh2931
reviewed
Dec 20, 2023
| logFile = Utils.getNodeDataDir(catchupNodeNum) + "/stderr.txt" | ||
| f = open(logFile) | ||
| contents = f.read() | ||
| if contents.count("unlinkable_block_exception") > 3: # a few are fine |
There was a problem hiding this comment.
Maybe you can even make it to 10 to prevent test flakeness.
There was a problem hiding this comment.
Lets see how it goes. If we see flakiness then we can adjust up.
linh2931
approved these changes
Dec 20, 2023
greg7mdp
approved these changes
Dec 20, 2023
This was referenced Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
nodeos_startup_catchup.pytest to sync with--block-log-retain-blocks=0and verify nounlinkableblocks.Test fails before #2007 fix.
Resolves #2006