Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When setting block-log-retain-blocks = 0 get lots of unlinkable blocks errors #2006

Closed
matthewdarwin opened this issue Dec 20, 2023 · 2 comments · Fixed by #2007, #2009, #2008, #2014 or #2015
Closed

When setting block-log-retain-blocks = 0 get lots of unlinkable blocks errors #2006

matthewdarwin opened this issue Dec 20, 2023 · 2 comments · Fixed by #2007, #2009, #2008, #2014 or #2015
Assignees
@heifner
Labels
👍 lgtm OCI Work exclusive to OCI team
Milestone
Leap v5.0.0

Comments

@matthewdarwin
Copy link

matthewdarwin commented Dec 20, 2023 •
edited
Loading

In 5.0.0-rc3, when setting block-log-retain-blocks = 0 get lots of unlinkable blocks errors. This worked fine in 3.2. Not tested in 4.0

Easy to reproduce on a heavy blockchain like wax, when starting from a snapshot. Seen on other lighter chains as well, even when starting from up-to-date.
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Dec 20, 2023
@heifner heifner self-assigned this Dec 20, 2023
@heifner
Copy link
Member

heifner commented Dec 20, 2023

Reproduced on eos mainnet by starting from a June snapshot.

@heifner heifner added the OCI Work exclusive to OCI team label Dec 20, 2023
@heifner heifner moved this from Todo to In Progress in Team Backlog Dec 20, 2023
heifner added a commit that referenced this issue Dec 20, 2023
@heifner
GH-2006 Do not attempt to apply blocks <= LIB
468aad6
@heifner
Copy link
Member

heifner commented Dec 20, 2023

Not reproducible on 4.0 during my testing.

@heifner heifner added this to the Leap v5.0.0 milestone Dec 20, 2023
@heifner heifner mentioned this issue Dec 20, 2023
Merged
@heifner heifner linked a pull request Dec 20, 2023 that will close this issue
[5.0] Fix unlinkable block exceptions when block-log-retain-blocks = 0 #2007
Merged
heifner added a commit that referenced this issue Dec 20, 2023
@heifner
GH-2006 Check for unlinkable blocks while syncing
6539271
heifner added a commit that referenced this issue Dec 20, 2023
@heifner
Merge pull request #2007 from AntelopeIO/GH-2006-unlinkable-blocks-5.0
89e2db1 
[5.0] Fix unlinkable block exceptions when block-log-retain-blocks = 0
heifner added a commit that referenced this issue Dec 20, 2023
@heifner
Merge branch 'release/5.0' into GH-2006-test-no-block-log-sync
0941a88
heifner added a commit that referenced this issue Dec 20, 2023
@heifner
Merge remote-tracking branch 'origin/release/5.0' into GH-2006-unlink…
0fb49ec 
…able-blocks-main
@heifner heifner mentioned this issue Dec 20, 2023
Merged
heifner added a commit that referenced this issue Dec 20, 2023
@heifner
Merge pull request #2009 from AntelopeIO/GH-2006-unlinkable-blocks-main
952aedf 
[5.0 -> main] Fix unlinkable block exceptions when block-log-retain-blocks = 0
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Backlog Dec 20, 2023
@heifner heifner linked a pull request Dec 20, 2023 that will close this issue
[5.0] Test: Check for unlinkable blocks while syncing #2008
Merged
@arhag arhag reopened this Dec 20, 2023
@github-project-automation github-project-automation bot moved this from Done to Todo in Team Backlog Dec 20, 2023
@heifner heifner mentioned this issue Dec 20, 2023
Merged
heifner added a commit that referenced this issue Dec 20, 2023
@heifner
Merge pull request #2008 from AntelopeIO/GH-2006-test-no-block-log-sync
4becdd5 
[5.0] Test: Check for unlinkable blocks while syncing
heifner added a commit that referenced this issue Dec 20, 2023
@heifner
Merge remote-tracking branch 'origin/release/5.0' into GH-2006-test-n…
54633f0 
…o-block-log-sync-main
@heifner heifner mentioned this issue Dec 20, 2023
Merged
heifner added a commit that referenced this issue Dec 21, 2023
@heifner
GH-2006 Search for more precise error and provide a bit more tolerance
fddc8ed
@heifner heifner mentioned this issue Dec 21, 2023
Merged
@heifner heifner linked a pull request Dec 21, 2023 that will close this issue
[5.0] Test: Check for unlinkable blocks while syncing - 2 #2015
Merged
heifner added a commit that referenced this issue Dec 21, 2023
@heifner
GH-2006 Dangling reference
c0804e8
heifner added a commit that referenced this issue Dec 21, 2023
@heifner
GH-2006 Check for null
cb83d8f
heifner added a commit that referenced this issue Dec 21, 2023
@heifner
GH-2006 Check for null
2ba8a1a
heifner added a commit that referenced this issue Dec 21, 2023
@heifner
Merge pull request #2015 from AntelopeIO/GH-2006-fix-test-5.0
debef7f 
[5.0] Test: Check for unlinkable blocks while syncing - 2
heifner added a commit that referenced this issue Dec 21, 2023
@heifner
Merge remote-tracking branch 'origin/release/5.0' into GH-2006-test-n…
c8920c3 
…o-block-log-sync-main
heifner added a commit that referenced this issue Dec 21, 2023
@heifner
Merge pull request #2014 from AntelopeIO/GH-2006-test-no-block-log-sy…
1f118d3 
…nc-main

[5.0 -> main] Test: Check for unlinkable blocks while syncing
@github-project-automation github-project-automation bot moved this from Todo to Done in Team Backlog Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Archived in project
Milestone
Leap v5.0.0
5 participants
@heifner @ericpassmore @arhag @matthewdarwin @enf-ci-bot