Remove defer transaction configuration options and block incoming delayed transactions #1643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-block-ms and --incoming-defer-ratio
arhag
requested changes
Sep 15, 2023
…d blacklisted_transactions_total
heifner
requested changes
Sep 18, 2023
arhag
requested changes
Sep 18, 2023
arhag
requested changes
Sep 19, 2023
There was a problem hiding this comment.
#1556 says to also "block delayed transactions". This means the check in transaction_context::init_for_input_trx should be updated to disallow non-zero delay_sec for all transaction types (not just read-only and dry-run ones). It also means that transaction_context::schedule_transaction can be removed.
arhag
reviewed
Sep 19, 2023
I will updated the tests. |
arhag
requested changes
Sep 22, 2023
…sec removal instead of removing it outright
…n_test using msig contracts
…cked and delayed_action_blocked
heifner
requested changes
Sep 27, 2023
heifner
approved these changes
Sep 27, 2023
arhag
requested changes
Sep 28, 2023
…ion_test and minor refactoring
arhag
approved these changes
Sep 29, 2023
linh2931
changed the title
This was referenced Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved #1556
--max-scheduled-transaction-time-per-block-ms--incoming-defer-ratioprocess_scheduled_and_incoming_trxsdelayfromtransaction_contextclass