[5.0 -> main] Fix unlinked blocks caused by deferred trx removal #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eos_chainbase_allocation_test.py
…_DEFERRED_TRXS_STAGE_2 is activated
…E_DEFERRED_TRXS_STAGE_1 instead of DISABLE_DEFERRED_TRXS_STAGE_2
…_deferred_trxs_stage_1 is activated
… update disable_deferred_trxs_stage_1_no_op_test
[5.0] Fix unlinked blocks caused by deferred trx removal
heifner
approved these changes
Oct 11, 2023
greg7mdp
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlinked block error was encountered in a replay of mainnet. It was caused by disallowing any deferred trxs from changes introduced by #1643.
This PR
I have run replay tests from the mainnet and have passed the failed block 320405089 and trx 527bbf9029f604e7021be729c858fb520001c5c5413cbee2fc08dbcf735534bc,
starting from snapshot-2023-07-12-16-eos-v6-0319983883. The previously failed block was at Jul-14-2023, 10:33:36 PM. I also run tests starting from older snapshots and exercised more deferred transactions.
Merges
release/5.0intomainfor #1734Resolves #1730