Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.0] Fix unlinked blocks caused by deferred trx removal #1734

Merged
merged 12 commits into from
Oct 11, 2023
Merged

[5.0] Fix unlinked blocks caused by deferred trx removal #1734

merged 12 commits into from
Oct 11, 2023

Conversation

linh2931
Copy link
Member

@linh2931 linh2931 commented Oct 6, 2023

Resolved #1730.

Unlinked block error was encountered in a replay of mainnet. It was caused by blocking any deferred trxs by #1643.

This PR

  • restored deferred trxs handling in transaction_context
  • updated related tests

I have run replay tests from the mainnet and have passed the failed block 320405089 and trx 527bbf9029f604e7021be729c858fb520001c5c5413cbee2fc08dbcf735534bc,
starting from snapshot-2023-07-12-16-eos-v6-0319983883. The previously failed block was at Jul-14-2023, 10:33:36 PM.

I will do more replay tests over the weekend.

@linh2931 linh2931 requested review from heifner and arhag October 6, 2023 21:36
@linh2931
Copy link
Member Author

linh2931 commented Oct 9, 2023

I started another test from a January 2022 snapshot. I print out when a transaction's delay_sec is greater than 0. There were a number of them. The test has been running for 2 days and is going fine.

arhag
arhag approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@arhag arhag left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like we can now undo the modify_gto_for_canceldelay_test hack if we wanted to since libtester allows for delayed transactions to be properly created prior to stage 1 activation.

But I am good with the changes in this PR as is.

@linh2931
Copy link
Member Author

It seems like we can now undo the modify_gto_for_canceldelay_test hack if we wanted to since libtester allows for delayed transactions to be properly created prior to stage 1 activation.

But I am good with the changes in this PR as is.

Thanks. I will undo it on main later.

@linh2931
remove modify_gto_for_canceldelay_test, restore canceldelay_test, and…
7f50c71 
… update disable_deferred_trxs_stage_1_no_op_test
@linh2931 linh2931 merged commit f9bce76 into release/5.0 Oct 11, 2023
21 checks passed
@linh2931 linh2931 deleted the unlinked_block branch October 11, 2023 12:32
@linh2931 linh2931 mentioned this pull request Oct 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhag arhag arhag approved these changes

@heifner heifner heifner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@linh2931 @heifner @arhag