-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optimization options in OR-Tools / XPRESS, refactor #1837
Conversation
Watermelon AI SummaryAI Summary deactivated by flomnes GitHub PRs
Antares_Simulator is an open repo and Watermelon will serve it for free. |
@@ -241,7 +241,14 @@ static SimplexResult OPT_TryToCallSimplex( | |||
if (options.useOrtools) | |||
{ | |||
const bool keepBasis = (optimizationNumber == PREMIERE_OPTIMISATION); | |||
solver = ORTOOLS_Simplexe(&Probleme, solver, keepBasis); | |||
solver = ORTOOLS_Simplexe(&Probleme, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is getting long, we could create an appropriate struct for ortools/solver options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OptimizationOptions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had the same idea, without reading your comment. See these 2 consecutive commits
src/libs/antares/optimization-options/include/antares/optimization-options/options.h
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're close ! A few additional comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checkOrtoolsSolverSpecificParameters
is declared twice, but never defined or used. Please remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, failure occurs way too late. Solver specific parameters should be check at the start, not in ORTOOLS_Simplexe (during the simulation)
Yes, this was already discussed in #1837 (comment) |
Quality Gate passedIssues Measures |
This PR allows the user to specify solver specific parameters from the command line. The work on basis manipulation is deferred to a subsequent PR.
This PR adds a command-line argument :
--solver-parameters="param1 value1 param2 value2"
to specify solver specific parametersThe parameter syntax is solver specfic, and the user should refer to the specific solver documentation to know how to set the wanted parameters. PR #2042 will give some explicit examples.
Allow the user to change the following properties
Use basis for 1st resolutionUse basis for 2nd resolutionPrimal toleranceDual toleranceUse a single structure for all these options.