-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ANT-1224] Preparing loop around benders solver #739
Conversation
Watermelon AI SummaryAI Summary deactivated by a-zakir GitHub PRs
antares-xpansion is an open repo and Watermelon will serve it for free. |
Quality Gate failedFailed conditions B Maintainability Rating on New Code (required ≥ A) See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
benders by batch + external loop: 1*100 + 1*10 = 110 | ||
*/ | ||
|
||
auto benders_algo_score = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe simpler if BENDERSMETHOD is a "tuple" (bool by_batch, bool external_loop). I do not know if doing such a thing is easy
benders_loggers.AddLogger(logger); | ||
benders_loggers.AddLogger(math_log_driver); | ||
switch (method) { | ||
case BENDERSMETHOD::BENDERS: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We see here that it may be used to characterize Benders method by a tuple as we only use only the "by batch" dimension
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
steps: - [x] create a storage struct for cuts data - [x] interface and its implementation(s) to save cuts data - [x] re-use cuts - [x] external loop criterion check - [x] add external loop constraint - [x] add "mathematical" logs for external loop (think about data to print) - [x] improve operational logs with external loop - [x] Computation of initial lambda_max by solving investment free problem + check criterion -> raise warning / exception if not satisfied at this point - [ ] Handle infeasibility / errors / ... - [x] Write test #706
steps:
[ANT-1224] Loop around Benders to satisfy custom user's criterion #706