Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge classical and by batch benders #738

Merged
merged 25 commits into from
Feb 7, 2024
Merged

merge classical and by batch benders #738

merged 25 commits into from
Feb 7, 2024

Conversation

a-zakir
Copy link
Contributor

@a-zakir a-zakir commented Dec 26, 2023 •
edited
Loading

Goal:
one benders executable instead the classical benders and the by batch one.
how:
the choice of the algorithm is decided by the batch_size parameter

close #727

@watermelon-copilot-for-code-review Watermelon - Copilot For Code Review
Copy link

watermelon-copilot-for-code-review bot commented Dec 26, 2023 •
edited
Loading

Watermelon AI Summary

AI Summary deactivated by a-zakir

GitHub PRs

antares-xpansion is an open repo and Watermelon will serve it for free.
🍉🫶
Have you starred Watermelon?

@pull-request-size pull-request-size bot added size/L and removed size/M labels Dec 26, 2023
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
11.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@watermelon-copilot-for-code-review watermelon-copilot-for-code-review bot mentioned this pull request Dec 29, 2023
Merged
10 tasks
JasonMarechal25
JasonMarechal25 requested changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@JasonMarechal25 JasonMarechal25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good
Just a couple of nitpicking comments

src/cpp/benders/factories/BendersFactory.cpp Outdated Show resolved Hide resolved
src/cpp/benders/factories/BendersFactory.cpp Outdated Show resolved Hide resolved
@JasonMarechal25
Copy link
Contributor

Don't forget to add some details Why/What/How in the top comment

tbittar
tbittar requested changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@tbittar tbittar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 typos

src/cpp/benders/factories/BendersFactory.cpp Outdated Show resolved Hide resolved
tests/CMakeLists.txt Outdated Show resolved Hide resolved
@a-zakir a-zakir requested a review from tbittar February 6, 2024 18:02
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
8.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@a-zakir a-zakir merged commit b195dd8 into develop Feb 7, 2024
17 checks passed
@a-zakir a-zakir deleted the feature/merge-classical-and-by-batch-benders branch October 9, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonMarechal25 JasonMarechal25 JasonMarechal25 approved these changes

@tbittar tbittar tbittar approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

merge classical benders with by batch
3 participants
@a-zakir @JasonMarechal25 @tbittar