Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor common ClusterList class #1813

Merged
merged 58 commits into from
Dec 20, 2023
Merged

Refactor common ClusterList class #1813

merged 58 commits into from
Dec 20, 2023

Conversation

payetvin
Copy link
Contributor

@payetvin payetvin commented Dec 8, 2023 •
edited by guilpier-code
Loading

This PR handles a part of issue #1487 (simplify and clarify cluster lists) :

  • Removing common cluster list byIndex
  • Changing common cluster list cluster from std::map into std::vector
  • Handling consequences of previous items

@payetvin payetvin self-assigned this Dec 8, 2023
@watermelon-copilot-for-code-review Watermelon - Copilot For Code Review
Copy link

watermelon-copilot-for-code-review bot commented Dec 8, 2023 •
edited
Loading

Watermelon AI Summary

AI Summary deactivated by payetvin

GitHub PRs

Antares_Simulator is an open repo and Watermelon will serve it for free.
🍉🫶
Why not invite more people to your team?

@payetvin payetvin changed the title Fix/common list Refactor common ClusterList class Dec 8, 2023
@payetvin payetvin requested a review from flomnes December 18, 2023 16:52
flomnes
flomnes requested changes Dec 19, 2023
View reviewed changes
Copy link
Member

@flomnes flomnes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Minor remarks: style
  • Major remarks
    • std::erase, std::remove, etc.
    • typeID => revert to virtual function

src/libs/antares/study/parts/common/cluster.cpp Outdated Show resolved Hide resolved
src/libs/antares/study/parts/common/cluster_list.cpp Show resolved Hide resolved
src/libs/antares/study/parts/common/cluster_list.cpp Show resolved Hide resolved
src/libs/antares/study/parts/common/cluster_list.h Outdated Show resolved Hide resolved
src/libs/antares/study/parts/common/cluster_list.h Outdated Show resolved Hide resolved
src/libs/antares/study/parts/thermal/container.cpp Outdated Show resolved Hide resolved
src/ui/simulator/toolbox/components/map/manager.cpp Show resolved Hide resolved
@watermelon-copilot-for-code-review watermelon-copilot-for-code-review bot mentioned this pull request Dec 19, 2023
Closed
@watermelon-copilot-for-code-review watermelon-copilot-for-code-review bot mentioned this pull request Dec 19, 2023
Merged
@payetvin payetvin merged commit fbf0ade into fix/renew-lists Dec 20, 2023
5 checks passed
@payetvin payetvin deleted the fix/common-list branch December 20, 2023 14:37
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

21 New issues
0 Security Hotspots
16.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@watermelon-copilot-for-code-review watermelon-copilot-for-code-review bot mentioned this pull request Dec 26, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@watermelon-copilot-for-code-review watermelon-copilot-for-code-review[bot] watermelon-copilot-for-code-review[bot] left review comments

@guilpier-code guilpier-code guilpier-code requested changes

@a-zakir a-zakir a-zakir left review comments

@flomnes flomnes flomnes requested changes

@sylvlecl sylvlecl Awaiting requested review from sylvlecl

Assignees

@payetvin payetvin

Labels
cleaning code quality PR: waiting for correction size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@payetvin @a-zakir @sylvlecl @flomnes @guilpier-code