Merge branch release/8.8.x into develop (changelog, version number) #1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing ST objects (#1807) - Add bool property `enabled` for each ST storage object - Whenever a ST storage is not `enabled`, remove it from computations relatively early (right after loading the data), using a similar mechanism as thermal & renewable clusters - Also fix list.ini files containing only the last ST storage object because of overwrite, add unit test case - Cherry-pick of "Remove sts container (#1804)" --------- Co-authored-by: Vincent Payet <[email protected]> Co-authored-by: payetvin <[email protected]>
Watermelon AI SummaryAI Summary deactivated by flomnes GitHub PRs
Antares_Simulator is an open repo and Watermelon will serve it for free. |
flomnes
commented
Dec 21, 2023
| @@ -278,14 +278,16 @@ class STstorageCashFlowByCluster : public Variable::IVariable<STstorageCashFlowB | |||
| const auto& shortTermStorage = results.data.area->shortTermStorage; | |||
|
|
|||
| // Write the data for the current year | |||
| for (uint clusterIndex = 0; clusterIndex < nbClusters_; ++clusterIndex) | |||
| uint clusterIndex = 0; | |||
There was a problem hiding this comment.
clusterIndex appears to be unused
a-zakir
reviewed
Dec 21, 2023
a-zakir
approved these changes
Dec 21, 2023
flomnes
changed the title
Co-authored-by: abdoulbari zakir <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated changelog, version number