Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE - BUILDING EXECUTABLES RTE-I #1832

Closed

Conversation

Milos-RTEi
Copy link
Collaborator

@Milos-RTEi Milos-RTEi commented Dec 19, 2023

Temporary PR for building executables for maintenance planning rte-i cr27

Please find specifications here.

There is also un discussion here.

Copy link

watermelon-copilot-for-code-review bot commented Dec 19, 2023

Watermelon AI Summary

AI Summary deactivated by Milos-RTEi

GitHub PRs

Antares_Simulator is an open repo and Watermelon will serve it for free.
🍉🫶
Why not invite more people to your team?

@JasonMarechal25 JasonMarechal25 marked this pull request as draft December 19, 2023 13:51
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

241 New issues
0 Security Hotspots
0.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@flomnes flomnes closed this Jan 9, 2024
@guilpier-code
Copy link
Contributor

guilpier-code commented Apr 12, 2024

  • Is there any documentation about what we want to do here ? Review would be easier.
  • Why is this PR closed (after all this work...)

@Milos-RTEi
Copy link
Collaborator Author

  • Is there any documentation about what we want to do here ? Review would be easier.
    This is the development for phase-I.
    phase-I is described in the specification (sent in an email yesterday) also there is a link in RTE-I PR header.
    phase-II was not yet developed - includes implementation in official Antares (so getting RTE review and approval).
  • Why is this PR closed (after all this work...)
    This was a temporary PR just to make executables and deliver them to the client->Elia for testing.
    The work was done on RTE-I repository. And if phase two happens we will continue to work there and share with RTE part-by-part for review (so as to avoid bug PRs).

As I mentioned in the meeting, the future of this CR (phase-II) is not sure (depending on the client's budget). So we are keeping it a LOW priority on our side.
And focusing on CR25 - Final Reservoir level (already paid by client-APG) that we want to deliver soon.

@guilpier-code
Copy link
Contributor

guilpier-code commented Apr 12, 2024

ok, thank you for these pieces of information.
I allow myself to add some links to documentation in the PR description.
Furthermore, I'll read it when the PR is reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants