Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use licence MPL 2.0 instead of GPL3_WITH_RTE-Exceptions #1812

Merged
merged 23 commits into from
Feb 2, 2024

Conversation

flomnes
Copy link
Member

@flomnes flomnes commented Dec 8, 2023

As of [YYYY/MM/DD], RTE Group, holding exclusive copyright rights, has announced a significant update in their software licensing policy for Antares Simulator. With the release of the major 9.0 version of Antares Simulator, RTE Group is transitioning from the GNU General Public License Version 3 (GPL-3) to the Mozilla Public License Version 2.0 (MPL-2.0). This strategic move reflects RTE Group's ongoing commitment to fostering an open, collaborative development environment while ensuring a balanced approach to copyright management and distribution flexibility.

Copy link

watermelon-copilot-for-code-review bot commented Dec 8, 2023

Watermelon AI Summary

AI Summary deactivated by flomnes

GitHub PRs

No results found in Jira Tickets :(

No results found in Confluence Docs :(

No results found in Slack Threads :(

No results found in Notion Pages :(

No results found in Linear Tickets :(

No results found in Asana Tasks :(

Antares_Simulator is an open repo and Watermelon will serve it for free.
🍉🫶

Copy link

sonarqubecloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@flomnes
Copy link
Member Author

flomnes commented Dec 12, 2023

We need a major version for this, so that would be 9.0

@flomnes flomnes added this to the 9.0 milestone Dec 12, 2023
@a-zakir
Copy link
Contributor

a-zakir commented Dec 14, 2023

This has been the largest search&replace in the history of search&replaces, maybe ever !

congrats m8

Copy link
Contributor

@a-zakir a-zakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely agree!

Copy link

@0x62646f727465 0x62646f727465 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My review as the OSPO Director at RTE:

  • 0) Not only src subdirectroy, please consider the docs subdirectory and root md files also

Example for doc subdir: docs/reference-guide/12-attribution_notices.md presents GNU GPL informations.
Example for /*.md file: README.md

  • 1) Correct the Copyright notice

Please respect this exact pattern:

Copyright (c) [FIRSTYEAR]-2023, RTE (https://www.rte-france.com)
See AUTHORS.txt
SPDX-License-Identifier: MPL-2.0
This file is part of Antares-Simulator, Adequacy and Performance assesment for interconnected energy networks.

[FIRSTYEAR] must be the oldest year of the copyright to consider in the updated file
As we are releasing a major version we will update the Copyright year
If you will release the 9.0 version after January 1st then it will be 2024
Warning: do not update the copyright of others (ex. Matsumoto's once)

  • 2) Correct the SPDX-License-Identifier from MPL2.0 to MPL2.0

Please replace all "SPDX-License-Identifier: MPL 2.0" by "SPDX-License-Identifier: MPL-2.0"

  • 3) Post commit please correct the published documentation

  • 3.a) Readthedocs.io

Correct Flags from GPLv3 to MPLv2
Replace GPL V3 by MPL V2

No changes should be made in license.md

  • 5) Double check src/libs/antares/*

For example, Merseen-Twister appears to be a BSD Licence and there's no reference to it

  • 6) commit and commit comment

The Version 9.0 changelog should be dedicated to the License change
No feature should be mixed with. A 9.1 version will.

The comment of this commit should precise:
As of [YYYY/MM/DD], RTE Group, holding exclusive copyright rights, has announced a significant update in their software licensing policy for Antares-Simulator. With the release of the major 9.0 version of Antares-Simulator, RTE Group is transitioning from the GNU General Public License Version 3 (GPLv3) to the Mozilla Public License Version 2.0 (MPL V2.0). This strategic move reflects RTE Group's ongoing commitment to fostering an open, collaborative development environment while ensuring a balanced approach to copyright management and distribution flexibility.

@JasonMarechal25
Copy link
Contributor

What about files without licence head ?

@flomnes flomnes modified the milestones: 9.0, Sprint 1 Jan 29, 2024
src/libs/antares/benchmarking/DurationCollector.cpp Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@flomnes flomnes merged commit af39797 into develop Feb 2, 2024
4 checks passed
@flomnes flomnes deleted the fix/lgpl-mpl-20 branch February 2, 2024 10:22
Copy link

sonarqubecloud bot commented Feb 2, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants