TRD;) tracking task in mc workflow #1467

nasirmehdimalik · 2024-02-16T13:01:28Z

No description provided.

martenole

Thanks @nasirmehdimalik . I have only some minor comments

martenole · 2024-02-16T13:13:08Z

MC/config/QC/json/trd-digits-task.json

+        "cycleDurationSeconds": "60",
+        "dataSource": {
+          "type": "direct",
+           "query": "digits:TRD/DIGITS;tracklets:TRD/TRACKLETS;triggers:TRD/TRKTRGRD;noiseMap:TRD/NOISEMAP/0?lifetime=condition&ccdb-path=TRD/Calib/NoiseMapMCM;chamberStatus:TRD/CHSTATUS/0?lifetime=condition&ccdb-path=TRD/Calib/HalfChamberStatusQC;fedChamberStatus:TRD/FCHSTATUS/0?lifetime=condition&ccdb-path=TRD/Calib/DCSDPsFedChamberStatus"


I don't think you need to query the digits for the tracklets task

martenole · 2024-02-16T13:13:34Z

MC/config/QC/json/trd-tracking-task.json

+        "host": "ccdb-test.cern.ch:8080",
+        "username": "not_applicable",
+        "password": "not_applicable",
+        "name": "not_applicable"


all these not_applicable entries can be removed

I'm keeping them because all other JSON files have the same structure, and I'm unsure if they might be needed later

But we should try to keep the json files as compact as possible. It makes maintenance easier. So please remove them. If there are other TRD QC json files where you find this you could even clean them up there as well :)

martenole · 2024-02-16T13:14:14Z

MC/config/QC/json/trd-tracking-task.json

+        "moduleName": "QcTRD",
+        "detectorName": "TRD",
+        "cycleDurationSeconds": "60",
+        "maxNumberCycles": "-1",


this is the default in any case, so not needed

without this lines gives error
`
std::exception::what: No such node (moduleName)

terminate called after throwing an instance of 'boost::wrapexceptboost::property_tree::ptree_bad_path'
what(): No such node (moduleName)

I'm quite sure Ole meant maxNumberCycles, not moduleName

Yes indeed. @nasirmehdimalik can you please remove maxNumberCycles?

martenole

Approving only to start the CI

martenole

Thanks @nasirmehdimalik ! Now that I look at it again, could you please also change the name trd-digits-task.json to something like trd-standalone-tasks.json? This would reflect that also the tracklets task is there and in the future all QC tasks not requiring any other detector could go there.

martenole

Looks good to me now. Could you just also add the TPC-TRD matches please? Online we disable the TPC-TRD matching, but in the asynch. processing it is there, so we should also check the QC for it. Sorry didn't notice this earlier in you PR. But this is a tiny change and then we should be ready for merging it

martenole · 2024-03-04T12:37:48Z

MC/config/QC/json/trd-tracking-task.json

+        "cycleDurationSeconds": "60",
+        "dataSource": {
+          "type": "direct",
+          "query": "trackITSTPCTRD:TRD/MATCH_ITSTPC;trigITSTPCTRD:TRD/TRGREC_ITSTPC"


Can you please add also TPC-TRD matches to the query here?

MC/config/QC/json/trd-tracking-task.json

Co-authored-by: Ole Schmidt <[email protected]>

MC/config/QC/json/trd-tracking-task.json

martenole

Should be fine now, let's wait for the CI to finish

nasirmehdimalik · 2024-03-05T04:40:08Z

@martenole since the checks fail and I pasted here the error "[ERROR] invalid workflow in o2-qc: No matching output found for <matcher query: (and origin:TRD (and description:MATCH_TPC (just startTime:$0 )))> as requested by data processor "qc-task-TRD-Tracking"". I think it is due to last commit.

martenole · 2024-03-05T08:27:53Z

@sawenzel it seems in the simulation check the matching of TRD to TPC tracks is disabled. Can you explain to me how the trd_track_sources are obtained in

O2DPG/MC/bin/o2dpg_sim_workflow.py

Line 1013 in 826526f

    
           trd_track_sources = anchorConfig.get('o2-trd-global-tracking-options', {}).get('track-sources', 'TPC,ITS-TPC')

?
Which configuration is used for the CI test here?

MC/bin/o2dpg_sim_workflow.py

benedikt-voelkel · 2024-03-07T13:49:29Z

From my side we can go ahead with this, @martenole @nasirmehdimalik

* TRD;) tracking task in mc workflow * rmove digit query from tracklet task * removed not maxNumberCycles, applicable items * trd-digit-task name change to trd-standalone-task * Update MC/config/QC/json/trd-tracking-task.json Co-authored-by: Ole Schmidt <[email protected]> * Update MC/config/QC/json/trd-tracking-task.json * readerCommand configured with TPC_TRD --------- Co-authored-by: Ole Schmidt <[email protected]>

TRD;) tracking task in mc workflow

90c2742

nasirmehdimalik requested review from sawenzel, chiarazampolli, gconesab and benedikt-voelkel as code owners February 16, 2024 13:01

martenole reviewed Feb 16, 2024

View reviewed changes

rmove digit query from tracklet task

0330c7c

martenole approved these changes Feb 19, 2024

View reviewed changes

martenole reviewed Feb 26, 2024

View reviewed changes

removed not maxNumberCycles, applicable items

ceb7e22

nasirmehdimalik force-pushed the master branch from bea01c2 to ceb7e22 Compare February 26, 2024 12:55

trd-digit-task name change to trd-standalone-task

a626c03

martenole reviewed Mar 4, 2024

View reviewed changes

Update MC/config/QC/json/trd-tracking-task.json

4381a4f

Co-authored-by: Ole Schmidt <[email protected]>

martenole reviewed Mar 4, 2024

View reviewed changes

MC/config/QC/json/trd-tracking-task.json Outdated Show resolved Hide resolved

Update MC/config/QC/json/trd-tracking-task.json

4ae352d

martenole approved these changes Mar 4, 2024

View reviewed changes

benedikt-voelkel reviewed Mar 5, 2024

View reviewed changes

MC/bin/o2dpg_sim_workflow.py Outdated Show resolved Hide resolved

readerCommand configured with TPC_TRD

f9cba95

martenole merged commit 10b933c into AliceO2Group:master Mar 7, 2024
6 checks passed

chiarazampolli mentioned this pull request Mar 14, 2024

MFT: new MC track task #1468

Merged

noferini added the async-2023-pbpb-apass3 label Apr 18, 2024

noferini added the async-2023-pbpb-apass3-accepted label Apr 19, 2024

benedikt-voelkel removed the async-2023-pbpb-apass3 label Jun 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TRD;) tracking task in mc workflow #1467

TRD;) tracking task in mc workflow #1467

nasirmehdimalik commented Feb 16, 2024

martenole left a comment

martenole Feb 16, 2024

nasirmehdimalik Feb 17, 2024

martenole Feb 16, 2024

nasirmehdimalik Feb 17, 2024

martenole Feb 26, 2024

nasirmehdimalik Feb 26, 2024

martenole Feb 16, 2024

nasirmehdimalik Feb 17, 2024

knopers8 Feb 19, 2024

martenole Feb 26, 2024

nasirmehdimalik Feb 26, 2024

martenole left a comment

martenole left a comment

martenole left a comment

martenole Mar 4, 2024

martenole left a comment

nasirmehdimalik commented Mar 5, 2024

martenole commented Mar 5, 2024

benedikt-voelkel commented Mar 7, 2024

TRD;) tracking task in mc workflow #1467

TRD;) tracking task in mc workflow #1467

Conversation

nasirmehdimalik commented Feb 16, 2024

martenole left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

martenole left a comment

Choose a reason for hiding this comment

martenole left a comment

Choose a reason for hiding this comment

martenole left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

martenole left a comment

Choose a reason for hiding this comment

nasirmehdimalik commented Mar 5, 2024

martenole commented Mar 5, 2024

benedikt-voelkel commented Mar 7, 2024