-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MFT: new MC track task #1468
MFT: new MC track task #1468
Conversation
Hi @chiarazampolli, I have added the new MFT MC task. Could you please check if everything is correct? Thanks! |
@diana0x0f we will also see if the QC goes through since there is a small test that will automatically take your new QCs into account. |
Hi @benedikt-voelkel , |
Hej @diana0x0f ,
Then run O2DPG_TEST_REPO_DIR=${O2DPG_DEV} O2DPG_TEST_HASH_BASE=HEAD~${N} ${O2DPG_ROOT}/test/run_workflow_tests.sh That should run the same thing. Let me know if you experience any issues. |
This needs AliceO2Group/QualityControl#2115 which does not seem to be contained in any QC tag. |
@benedikt-voelkel There will be a tag tomorrow. Is it ok to have a new tag or do you need a patch on an existing QC tag ? |
I guess it would be important to have that one in before we merge this. |
If this is for MC anchored to data, we need to patch the QC tag that is used for MC for those data. |
Ok, so I am going to tag today a new version and if you want me to patch a specific tag, just let me know. It is very quick to do (perhaps ping me on MM). |
Hello @diana0x0f , |
Hi @chiarazampolli , this new MC task was not targeted specifically for any particular production at the moment. Our intention was to incorporate it into the codebase for any upcoming central MC production. |
@chiarazampolli I guess no labels needed, right? |
@TimoWilken |
Hi @benedikt-voelkel, sorry, known issue: https://its.cern.ch/jira/browse/O2-4735. The next automatic rebuild should fix it. Let me know if it's urgent, then I'll restart it manually, or you can merge it right away. |
Thanks! |
Hello @benedikt-voelkel , |
I understood that it is not urgent but as @diana0x0f said
No rush from my side. Personally, I cannot comment. |
Hi @benedikt-voelkel , @chiarazampolli , |
Ciao @diana0x0f , I added your task here: https://gitlab.cern.ch/bvolkel/o2dpgdocs/-/blob/main/docs/software/requests/2023pbpb_apass.md Please, do like that next time you need a cherry-pick in a production tag. Chiara |
BTW, do we need also to update the QC? Otherwise your task might not work. If this is the case, we need to ask for a tag to @Barthelemy . |
Hi @chiarazampolli , thanks! This task in QC was included in v1.135.0. |
Hello @diana0x0f , Then we need to retag QC. @Barthelemy , could you do so? We currently use v1.126.5 in production. Note the PR by @lmassacr too: she might need an update as well for QC (#1531), and the one by @martenole (#1467). They also might need an update of QC. Chiara |
Hi @chiarazampolli, @Barthelemy, So, if I am not mistaken, now we might only need to retag QC to include QC updates for #1531 and #1467 if that's the case. |
No description provided.