Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRD;) tracking task in mc workflow #1467

Merged
merged 7 commits into from
Mar 7, 2024
Merged

TRD;) tracking task in mc workflow #1467

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
90c2742
TRD;) tracking task in mc workflow
nasirmehdimalik Feb 16, 2024
0330c7c
rmove digit query from tracklet task
nasirmehdimalik Feb 17, 2024
ceb7e22
removed not maxNumberCycles, applicable items
nasirmehdimalik Feb 26, 2024
a626c03
trd-digit-task name change to trd-standalone-task
nasirmehdimalik Feb 26, 2024
4381a4f
Update MC/config/QC/json/trd-tracking-task.json
nasirmehdimalik Mar 4, 2024
4ae352d
Update MC/config/QC/json/trd-tracking-task.json
martenole Mar 4, 2024
f9cba95
readerCommand configured with TPC_TRD
nasirmehdimalik Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions MC/bin/o2dpg_qc_finalization_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ def add_QC_postprocessing(taskName, qcConfigPath, needs, runSpecific, prodSpecif
#add_QC_finalization('tpcTrackingQC', 'json://${O2DPG_ROOT}/MC/config/QC/json/tpc-qc-tracking-direct.json')
add_QC_finalization('tpcStandardQC', 'json://${O2DPG_ROOT}/MC/config/QC/json/tpc-qc-standard-direct.json')
add_QC_finalization('trdDigitsQC', 'json://${O2DPG_ROOT}/MC/config/QC/json/trd-digits-task.json')
add_QC_finalization('trdTrackingQC', 'json://${O2DPG_ROOT}/MC/config/QC/json/trd-tracking-task.json')
add_QC_finalization('vertexQC', 'json://${O2DPG_ROOT}/MC/config/QC/json/vertexing-qc-direct-mc.json')
add_QC_finalization('ITSTPCmatchQC', 'json://${O2DPG_ROOT}/MC/config/QC/json/ITSTPCmatchedTracks_direct_MC.json')
add_QC_finalization('TOFMatchQC', 'json://${O2DPG_ROOT}/MC/config/QC/json/tofMatchedTracks_ITSTPCTOF_TPCTOF_direct_MC.json')
Expand Down
5 changes: 5 additions & 0 deletions MC/bin/o2dpg_sim_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1210,6 +1210,11 @@ def addQCPerTF(taskName, needs, readerCommand, configFilePath, objectsFile=''):
readerCommand='o2-trd-trap-sim',
configFilePath='json://${O2DPG_ROOT}/MC/config/QC/json/trd-digits-task.json')

addQCPerTF(taskName='trdTrackingQC',
needs=[TRDTRACKINGtask2['name']],
readerCommand='o2-global-track-cluster-reader --track-types "ITS-TPC-TRD" --cluster-types none',
benedikt-voelkel marked this conversation as resolved.
Show resolved Hide resolved
configFilePath='json://${O2DPG_ROOT}/MC/config/QC/json/trd-tracking-task.json')

### TOF
addQCPerTF(taskName='tofDigitsQC',
needs=[getDigiTaskName("TOF")],
Expand Down
13 changes: 12 additions & 1 deletion MC/config/QC/json/trd-digits-task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,18 @@
"pulseheightpeaklower": "1.0",
"pulseheightpeakupper": "5.0"
}
}
},
"Tracklets": {
"active": "true",
"className": "o2::quality_control_modules::trd::TrackletsTask",
"moduleName": "QcTRD",
"detectorName": "TRD",
"cycleDurationSeconds": "60",
"dataSource": {
"type": "direct",
"query": "digits:TRD/DIGITS;tracklets:TRD/TRACKLETS;triggers:TRD/TRKTRGRD;noiseMap:TRD/NOISEMAP/0?lifetime=condition&ccdb-path=TRD/Calib/NoiseMapMCM;chamberStatus:TRD/CHSTATUS/0?lifetime=condition&ccdb-path=TRD/Calib/HalfChamberStatusQC;fedChamberStatus:TRD/FCHSTATUS/0?lifetime=condition&ccdb-path=TRD/Calib/DCSDPsFedChamberStatus"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need to query the digits for the tracklets task

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

}
}
},
"dataSamplingPolicies": []
}
Expand Down
48 changes: 48 additions & 0 deletions MC/config/QC/json/trd-tracking-task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
{
"qc": {
"config": {
"database": {
"implementation": "CCDB",
"host": "ccdb-test.cern.ch:8080",
"username": "not_applicable",
"password": "not_applicable",
"name": "not_applicable"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all these not_applicable entries can be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm keeping them because all other JSON files have the same structure, and I'm unsure if they might be needed later

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we should try to keep the json files as compact as possible. It makes maintenance easier. So please remove them. If there are other TRD QC json files where you find this you could even clean them up there as well :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

},
"Activity": {
"number": "42",
"type": "2",
"provenance": "qc_mc",
"passName": "passMC",
"periodName": "SimChallenge"
},
"monitoring": {
"url": "no-op://"
},
"consul": {
"url": ""
},
"conditionDB": {
"url": "alice-ccdb.cern.ch"
}
},
"tasks": {
"Tracking": {
"active": "true",
"className": "o2::quality_control_modules::trd::TrackingTask",
"moduleName": "QcTRD",
"detectorName": "TRD",
"cycleDurationSeconds": "60",
"maxNumberCycles": "-1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the default in any case, so not needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without this lines gives error
`
std::exception::what: No such node (moduleName)

terminate called after throwing an instance of 'boost::wrapexceptboost::property_tree::ptree_bad_path'
what(): No such node (moduleName)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm quite sure Ole meant maxNumberCycles, not moduleName

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes indeed. @nasirmehdimalik can you please remove maxNumberCycles?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

"dataSource": {
"type": "direct",
"query": "trackITSTPCTRD:TRD/MATCH_ITSTPC;trigITSTPCTRD:TRD/TRGREC_ITSTPC"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add also TPC-TRD matches to the query here?

martenole marked this conversation as resolved.
Show resolved Hide resolved
},
"taskParameters": {
"detailedQC": "false",
"trackSources": "ITS-TPC-TRD"
nasirmehdimalik marked this conversation as resolved.
Show resolved Hide resolved
}
}
},
"dataSamplingPolicies": []
}
}