Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix this version of WritePlotFile to use SuperParticle, as expected by WriteBinaryParticleData #3449

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

atmyers
Copy link
Member

@atmyers atmyers commented Jul 26, 2023

Fixes these issues seen in the WarpX CI:

https://github.com/ECP-WarpX/WarpX/actions/runs/5649976693/job/15305447602?pr=3474
https://github.com/ECP-WarpX/WarpX/actions/runs/5649976693/job/15305447804?pr=3474

Summary

Additional background

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@WeiqunZhang WeiqunZhang merged commit a3b69fa into AMReX-Codes:development Jul 26, 2023
66 checks passed
WeiqunZhang added a commit that referenced this pull request Jul 26, 2023
… to use constexpr if (#3448)

This results in much easier-to-interpret error messages, useful in
finding #3449 and #3450

Co-authored-by: Weiqun Zhang <[email protected]>
@ax3l
Copy link
Member

ax3l commented Jul 26, 2023

Thank you 😊🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants