Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor call_f in ParticleTransformation and WriteBinaryParticleData to use constexpr if #3448

Merged
merged 6 commits into from
Jul 26, 2023
Merged

Refactor call_f in ParticleTransformation and WriteBinaryParticleData to use constexpr if #3448

merged 6 commits into from
Jul 26, 2023

Conversation

atmyers
Copy link
Member

@atmyers atmyers commented Jul 25, 2023 •
edited
Loading

This results in much easier-to-interpret error messages, useful in finding #3449 and #3450

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@atmyers atmyers requested review from WeiqunZhang and ax3l July 25, 2023 22:05
@atmyers atmyers changed the title Work-around for nvcc not supporting first-capature in if constexpt scope Refactor call_f in particle code to use constexpr if Jul 25, 2023
@atmyers atmyers changed the title Refactor call_f in particle code to use constexpr if Refactor call_f in ParticleTransformation and WriteBinaryParticleData to use constexpr if Jul 25, 2023
WeiqunZhang
WeiqunZhang requested changes Jul 26, 2023
View reviewed changes
Src/Particle/AMReX_ParticleTransformation.H Outdated Show resolved Hide resolved
Src/Particle/AMReX_ParticleTransformation.H Outdated Show resolved Hide resolved
Src/Particle/AMReX_ParticleTransformation.H Outdated Show resolved Hide resolved
@WeiqunZhang WeiqunZhang enabled auto-merge (squash) July 26, 2023 04:14
@WeiqunZhang WeiqunZhang merged commit 8aa7dc6 into AMReX-Codes:development Jul 26, 2023
66 checks passed
This was referenced Jul 26, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeiqunZhang WeiqunZhang WeiqunZhang approved these changes

@ax3l ax3l Awaiting requested review from ax3l

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atmyers @WeiqunZhang