Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix styling of search results in ContentPicker in WordPress 6.3 #252

Merged
merged 5 commits into from
Aug 30, 2023

Conversation

fabiankaegy
Copy link
Member

Description of the Change

Before After
Before After

Closes #233

How to test the Change

Changelog Entry

Fixed - Rendering of Search Results of Content Picker in WordPress 6.3

Credits

Props @av3nger @fabiankaegy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@fabiankaegy fabiankaegy self-assigned this Aug 24, 2023
@github-actions
Copy link

github-actions bot commented Aug 24, 2023

Size Change: +455 B (+1%)

Total Size: 54 kB

Filename Size Change
dist/index.js 54 kB +455 B (+1%)

compressed-size-action

@cypress
Copy link

cypress bot commented Aug 25, 2023

Passing run #630 ↗︎

0 6 0 0 Flakiness 0

Details:

Merge branch 'develop' into fix/content-picker-search-item-styling-wp-6-3
Project: 10up Block Components Commit: f9f59520e4
Status: Passed Duration: 04:14 💡
Started: Aug 30, 2023 6:22 AM Ended: Aug 30, 2023 6:26 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@fabiankaegy fabiankaegy temporarily deployed to testing August 28, 2023 11:24 — with GitHub Actions Inactive
@github-actions
Copy link

🎉 A new testing version of this package has been published to NPM. You can install it with npm install @10up/block-components@testing-252

@av3nger
Copy link

av3nger commented Aug 29, 2023

This works. However, when placed inside the InspectorControls element, the padding between results is a bit too small, IMHO

Screenshot 2023-08-29 at 10 13 55

@fabiankaegy
Copy link
Member Author

Updated and fixed :)

@fabiankaegy fabiankaegy merged commit a3c79a3 into develop Aug 30, 2023
6 of 7 checks passed
@fabiankaegy fabiankaegy deleted the fix/content-picker-search-item-styling-wp-6-3 branch August 30, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WordPress 6.3 Compatibility Testing
3 participants