Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContentPicker search results appear broken in WordPress 6.3 #260

Closed
1 task done
JakePT opened this issue Aug 31, 2023 · 1 comment
Closed
1 task done

ContentPicker search results appear broken in WordPress 6.3 #260

JakePT opened this issue Aug 31, 2023 · 1 comment
Labels

Comments

@JakePT
Copy link

JakePT commented Aug 31, 2023

Describe the bug

The search results in the ContentPicker component appear broken in WordPress 6.3.

They appear correct in WordPress 6.2. The main difference seems to be that in WordPress 6.3 the button element for each result is not receiving styles for the .block-editor-link-control__search-item selector, even though this class is still present.

Steps to Reproduce

Using WordPress 6.2 with a ContentPicker component that has been implemented like this:

<ContentPicker
	content={posts}
	contentTypes={['post']}
	isOrderable
	label={__('Posts')}
	maxContentItems={7}
	onPickChange={onChangePosts}
	placeholder={__('Search posts')}
/>
  1. Perform a search for posts. The results should appear as expected.
  2. Update to WordPress 6.3.1.
  3. Perform the same search, the list will appear broken as shown below.

Screenshots, screen recording, code snippet

Screenshot 2023-08-31 at 3 17 49 pm

Environment information

No response

WordPress information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@fabiankaegy
Copy link
Member

Hey @JakePT 👋

Thanks for the report! We actually just fixed this in #252. So version 1.16.3 of the block components package should contain a fix for it.

Let me know if you are still running into issues with that version.

For now I will close this ticket :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants