Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix only register icon store if not already present #253

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

fabiankaegy
Copy link
Member

Description of the Change

Fix only register icon store if it isn't already registered

Closes #252

How to test the Change

Changelog Entry

Fixed - only register icon store if it isn't already registered

Credits

Props @fabiankaegy @av3nger

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@github-actions
Copy link

Size Change: +25 B (0%)

Total Size: 53.6 kB

Filename Size Change
dist/index.js 53.6 kB +25 B (0%)

compressed-size-action

@cypress
Copy link

cypress bot commented Aug 24, 2023

Passing run #625 ↗︎

0 6 0 0 Flakiness 0

Details:

Merge branch 'develop' into fix/only-register-store-if-not-already-present
Project: 10up Block Components Commit: 2998b403c7
Status: Passed Duration: 02:54 💡
Started: Aug 28, 2023 11:23 AM Ended: Aug 28, 2023 11:25 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@fabiankaegy fabiankaegy marked this pull request as ready for review August 24, 2023 08:24
@av3nger
Copy link

av3nger commented Aug 27, 2023

@fabiankaegy, how do I test this? I tried building and copying over the dist files to the project node_modules folder, but then the project is not being built. I tried replacing the whole package, also issues with building

@fabiankaegy fabiankaegy temporarily deployed to testing August 28, 2023 11:20 — with GitHub Actions Inactive
@github-actions
Copy link

🎉 A new testing version of this package has been published to NPM. You can install it with npm install @10up/block-components@testing-253

@fabiankaegy
Copy link
Member Author

@av3nger In order to make it easier to test I released a testing version to NPM. See #253 (comment)

@av3nger
Copy link

av3nger commented Aug 29, 2023

This fixes the issue. Thank you!

@fabiankaegy fabiankaegy merged commit a8bc0a0 into develop Aug 30, 2023
5 checks passed
@fabiankaegy fabiankaegy deleted the fix/only-register-store-if-not-already-present branch August 30, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants