Protobuf files generated during build #418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 17, 2023 18:06
Compiler flags is also set to linking step for stuff like -pthread and -fopenmp, which requires linkage to specific threading libraries.
|
We require contributors/corporates @lvella to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document |
|
We require contributors/corporates @lvella to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@lvella Thanks a lot for this pull request; the issue will be fixed in a separate push soon. |
This was referenced Aug 21, 2023
|
It looks like the protobuf files are still checked in the repo instead of being built at compile time (like the original PR suggested). Are there any plans for doing that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building upon my previous PR #415, this removes protobuf generated source code from the repository, instead they are automatically built and managed by make on the
builddirectory, as any other build artifact. This makes the code much more portable because it makes no assumption on the protobuf version installed.I made this a separated PR because this might be more controversial than PR #415.