Distro-agnostic compatibility with GCC 13 #512
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rewrite of README.md provides: - Improved grammar and sentence structure everywhere. - Better organization. - Instructions for dependencies on openSUSE and Arch.
This was referenced Aug 21, 2023
Closed
|
Apparently this pull request needs to be retargeted towards the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
zkevm-provercurrently will not compile under the most used desktop Linux distributions. A notable exception is Ubuntu 22.04, since that is what a lot of developers in the Polygon Labs zkEVM Prover Team use.This leads to problems:
zkevm-prover, since I am one of the five people on Earth who use openSUSE,zkevm-provereither, because they use Arch, GCC 13, or a too-new version of protobuf, etc.As such, it's very important to make the repository agnostic to:
...which is what this pull request does.
This pull request also provides an improved
README.mdwhich includes:Finally, this pull request provides better tooling for downloading that gargantuan 75GB archive that we need to get the prover working.
A separate pull request for a submodule dependency (
goldilocks) has already been merged and fixes this same problem (which appeared in a much less pronounced fashion) over there: 0xPolygonHermez/goldilocks#42This pull request has been fully tested locally.